-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update account deleted page to allow restore behind feature flag #96446
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~236 bytes removed 📉 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~42230 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~4666 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17004441 Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Hi @candy02058912, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:
Thank you in advance! |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17004441 Thank you @candy02058912 for including a screenshot in the description! This is really helpful for our translators. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @candy02058912. This looks good to me.
I left a comment about the loading state on restore button on the original issue. It’s not related to this functionality though, so shouldn’t block this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The page is left-aligned on mobile. I didn't expect it, but maybe it's by design?
The spinner component is also left-aligned which looks unexpected. I just wasn't quick enough to screenshot 😄
Everything else works great! I'll approve because the only comment that must be fixed is the missing translate()
call.
47b69c5
to
c1637f4
Compare
Thanks for mentioning that! I liked how it looked, so I didn't think much about it. I'll still merge the PR, as this isn't a blocker. |
This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17004441 Some locales (Hebrew) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday. Thank you @candy02058912 for including a screenshot in the description! This is really helpful for our translators. |
Apologies for the late response.
I think this makes sense. If we maintained the centred copy on smaller viewports the lines could wrap weirdly. Left-aligning ensures that the copy remains easily readable. |
Related to https://github.com/Automattic/dotcom-forge/issues/9460
Note
To keep this PR contained as it's already changing 10 files, let's focus on the functional aspects. If you notice any design improvements, please comment in the original issue
Proposed Changes
Update: I've also updated the deleting state screen to this:
Original flow (without restore function)
normal.flow.mp4
With the feature flag
?flags=me/account-restore
feature.mp4
Testing Instructions
Make sure we didn't break anything on production:
/me/account/close
and delete the accountEnable the feature flag
Note
Currently after refreshing
/me/account/closed
, it will redirect back to a login screen as we haven't yet allowed that page to be accessed in a logged out state. This will be addressed in https://github.com/Automattic/dotcom-forge/issues/9909Pre-merge Checklist