Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the default version of Odie specified in the backend #97333

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

robfelty
Copy link
Contributor

Now that we have decided to go ahead with the new help center experience, we would like to stop specifying the version in the client, and instead use the version specified in the backend, which is what we normally do. This will allow us to start our next A/B test. The only difference between 14.0.3 and 13.1.1 was the greeting, that 13.1.1 introduced itself as Wapuu. Even though we haven't totally moved to the new help center yet, using this small difference in the greeting for the old version should not degrade the user experience at all.

Thus with this change, for both the old Wapuu and the new help center experience, the user will be greeted by:

Howdy, I'm WordPress.com's support assistant

image

Testing Instructions

Try asking a question to the virtual assistant in the help center and ensure that it still works.

@robfelty robfelty requested a review from a team as a code owner December 11, 2024 14:35
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Async-loaded Components (~8 bytes removed 📉 [gzipped])

name                               parsed_size           gzip_size
async-load-automattic-help-center        -11 B  (-0.0%)       -8 B  (-0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Contributor

@marco-altran marco-altran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@robfelty robfelty merged commit dd411b6 into trunk Dec 11, 2024
18 checks passed
@robfelty robfelty deleted the odie-use-default-version branch December 11, 2024 16:20
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants