Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update masterbar and jetpack header logo #97318

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

ilyasfoo
Copy link
Contributor

Related to #97153

Proposed Changes

  • Update Woo logo for Jetpack auth header page
  • Update Woo logo for core profiler flow

Testing Instructions

  1. In your development.json, set woocommerce/rebrand-2-0 to true
  2. Run yarn start

Core profiler

  1. Go to core profiler connect flow (this URL)
  2. Observe the updated Woo logo
image

Shipping & tax

  1. Go to Shipping & Tax connect flow (this URL)
  2. Observe the updated Woo logo
image

Optional: Old onboarding

  1. Go to old onboarding connect flow (this URL)
  2. Observe the updated Woo logo
image

Optional 2: Regression test

  1. Disable feature flag and open all links in above instructions
  2. Observe the original Woo logo is shown instead

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@ilyasfoo ilyasfoo requested review from a team, psealock and chihsuan December 11, 2024 09:13
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 11, 2024
@matticbot
Copy link
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/woo-rebrand-jetpack-auth-pages on your sandbox.

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~56 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-login         +316 B  (+0.0%)      +56 B  (+0.0%)
entry-stepper        +95 B  (+0.0%)       +6 B  (+0.0%)
entry-main           +95 B  (+0.0%)       +6 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~84 bytes added 📈 [gzipped])

name              parsed_size           gzip_size
purchase-product       +221 B  (+0.1%)      +71 B  (+0.1%)
plugins                +221 B  (+0.0%)      +13 B  (+0.0%)
media                  +221 B  (+0.0%)      +13 B  (+0.0%)
jetpack-connect        +221 B  (+0.0%)      +71 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~711 bytes added 📈 [gzipped])

name                                                      parsed_size            gzip_size
async-load-calypso-components-jetpack-header-woocommerce      +1683 B  (+30.0%)     +640 B  (+42.9%)
async-load-calypso-layout-masterbar-woo-core-profiler          +224 B   (+4.5%)      +58 B   (+2.7%)
async-load-design-playground                                   +221 B   (+0.0%)      +13 B   (+0.0%)
async-load-design-blocks                                       +221 B   (+0.0%)      +13 B   (+0.0%)
async-load-design                                              +221 B   (+0.0%)      +13 B   (+0.0%)
async-load-calypso-post-editor-media-modal                     +221 B   (+0.0%)      +13 B   (+0.0%)
async-load-calypso-post-editor-editor-media-modal              +221 B   (+0.0%)      +13 B   (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants