Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design Picker: Group results by the best matching and categories (2nd try) #97314

Merged
merged 11 commits into from
Dec 11, 2024

Conversation

arthur791004
Copy link
Contributor

Related to #97263

Proposed Changes

Why are these changes being made?

Testing Instructions

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@arthur791004 arthur791004 self-assigned this Dec 11, 2024
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@arthur791004
Copy link
Contributor Author

The Pre-Release E2E Tests passed!

@arthur791004 arthur791004 merged commit fd674b4 into trunk Dec 11, 2024
11 checks passed
@arthur791004 arthur791004 deleted the feat/design-picker-group-designs branch December 11, 2024 07:11
@a8ci18n
Copy link

a8ci18n commented Dec 11, 2024

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17057736

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Hi @arthur791004, could you please edit the description of this PR and add a screenshot for our translators? Ideally it'd include all of the following strings:

  • No themes matched.
  • Best matching themes

Thank you in advance!

@arthur791004
Copy link
Contributor Author

Screenshots:

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants