Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable logged out for /me/account/closed #97201

Merged
merged 2 commits into from
Dec 8, 2024
Merged

Conversation

candy02058912
Copy link
Contributor

Fixes https://github.com/Automattic/dotcom-forge/issues/9909

Proposed Changes

  • Enable logged out for /me/account/closed
  • This should not change any existing behavior other than /me/account/closed page

Note that /me/account/closed currently defaults to the "Account is deleting" state but it's not doing anything. This is also the current production behavior if you are logged in and access /me/account/closed directly.
To be focused on enabling logged out for /me/account/closed, this will not be addressed in this PR.

expected@2x

Why are these changes being made?

  • Allow users to self-restore accounts pet6gk-1Em-p2

Testing Instructions

  • You are logged out
  • Go to calypso.localhost:3000/me/account/closed and it should be accessible
  • The other /me routes and will redirect to `/log-in?redirect_to=

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 7, 2024
@candy02058912 candy02058912 marked this pull request as ready for review December 7, 2024 17:18
@matticbot
Copy link
Contributor

matticbot commented Dec 7, 2024

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/me-routing-2 on your sandbox.

@matticbot
Copy link
Contributor

matticbot commented Dec 7, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~11 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
entry-stepper        +48 B  (+0.0%)      +11 B  (+0.0%)
entry-main           +48 B  (+0.0%)      +11 B  (+0.0%)
entry-login          +48 B  (+0.0%)      +11 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@candy02058912 candy02058912 requested a review from a team December 7, 2024 17:45
Copy link
Member

@p-jackson p-jackson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this better (even if it is editing a widely used controller)

The only other thing I can think of is leaving a comment at

{
name: 'account-close',
paths: [ '/me/account/close', '/me/account/closed' ],
module: 'calypso/me/account-close',
group: 'me',
},

to explain that enableLoggedOut doesn't work and it has been handled by a controller. But not required if you don't think that's useful.

@candy02058912 candy02058912 merged commit 814570e into trunk Dec 8, 2024
11 checks passed
@candy02058912 candy02058912 deleted the update/me-routing-2 branch December 8, 2024 18:31
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants