-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable logged out for /me/account/closed #97201
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
This PR modifies the release build for the following Calypso Apps: For info about this notification, see here: PCYsg-OT6-p2
To test WordPress.com changes, run |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~11 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this better (even if it is editing a widely used controller)
The only other thing I can think of is leaving a comment at
Lines 40 to 45 in caf55be
{ | |
name: 'account-close', | |
paths: [ '/me/account/close', '/me/account/closed' ], | |
module: 'calypso/me/account-close', | |
group: 'me', | |
}, |
to explain that enableLoggedOut
doesn't work and it has been handled by a controller. But not required if you don't think that's useful.
Fixes https://github.com/Automattic/dotcom-forge/issues/9909
Proposed Changes
/me/account/closed
pageNote that
/me/account/closed
currently defaults to the "Account is deleting" state but it's not doing anything. This is also the current production behavior if you are logged in and access/me/account/closed
directly.To be focused on enabling logged out for
/me/account/closed
, this will not be addressed in this PR.Why are these changes being made?
Testing Instructions
calypso.localhost:3000/me/account/closed
and it should be accessiblePre-merge Checklist