-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow free users with flag to set dotblog as primary #97200
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: App Entrypoints (~57 bytes added 📈 [gzipped])
Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used. Sections (~932 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~19 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
TestingRequirements
Browsers
|
Pausing testing because, for the time being, the project has been cancelled p1734369952367629-slack-C082K0YF2G6 |
Closing this PR. Context: https://github.com/Automattic/martech/issues/3561#issuecomment-2546239806 |
Related to https://github.com/Automattic/martech/issues/3561
Proposed Changes
This PR contains 2 changes:
CAMPAIGN_PRIMARY_DOTBLOG_ON_FREE_2024
flag is set for a user, allow the user to select a .blog domain and a free plan in the onboarding flow, without showing any dialog.CAMPAIGN_PRIMARY_DOTBLOG_ON_FREE_2024
flag is set for a user, allow the user to select a .blog domain as primary for a free site on the/domains/manage/<site slug>
screen.Why are these changes being made?
Testing Instructions
Testing the onboarding flow
/start
.Testing setting the .blog domain as primary
/domains/manage/<site slug>
where is for a site on the free plan with a .blog domain mapped to it.Testing to confirm that non .blog domains cannot be set as primary.
/domains/manage/<site slug>
.Testing for regressions
/domains/manage/<site slug>
for the same site.client/my-sites/domains/domain-management/components/primary-domain-selector/test/index.tsx
for additional cases.Pre-merge Checklist