Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain management revamp: update domain list column styles in sidebar #97193

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from

Conversation

Imran92
Copy link
Contributor

@Imran92 Imran92 commented Dec 6, 2024

Related to #96554

Proposed Changes

Updates the looks of the left side of the Domains preview

  • Fix the font size, spacing and styling of the Tab title ("Domains")
  • Fix the look and style of the button to add domains
  • Fix search bar
  • Fix spacings
  • Remove column names when showing domains only in sidebar
  • Fix hiding left column if size of tab view and smaller
  • Fix paddings of preview pane in mobile view

Why are these changes being made?

  • To revamp domain management

Testing Instructions

  • Go to wordpress.com/domains/manage
  • Browse around, check inner functionalities, make sure you see no issues in how the table looks and works
  • Open a site's wp-admin area, go to Upgrades -> Emails, browse around and make sure everything works as before
  • Also click on a few domains to make sure everything is working as before.
  • Now enable the feature flag by entering window.sessionStorage.setItem('flags', 'calypso/all-domain-management') in the - browser console. Reload the page
  • Now click on different domains. They should open in the new layout now.
  • Check that the left side of the new layout (the domains list) matches the design.
  • When you open wordpress.com/sites and click a site, the left side panel opens. The domains side panel should also match the sites side panel
Before After
Screenshot 2024-12-07 at 1 50 39 AM Screenshot 2024-12-07 at 3 06 44 AM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@Imran92 Imran92 requested a review from a team December 6, 2024 21:16
@Imran92 Imran92 self-assigned this Dec 6, 2024
@Imran92 Imran92 requested a review from a team as a code owner December 6, 2024 21:16
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Dec 6, 2024
@matticbot
Copy link
Contributor

matticbot commented Dec 6, 2024

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~165 bytes added 📈 [gzipped])

name           parsed_size           gzip_size
domains             +671 B  (+0.0%)     +165 B  (+0.0%)
site-overview        +18 B  (+0.0%)       +6 B  (+0.0%)
hosting              +18 B  (+0.0%)       +6 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@merkushin merkushin requested review from merkushin and removed request for merkushin December 9, 2024 14:54
@m1r0
Copy link
Member

m1r0 commented Dec 9, 2024

Looks good overall! I have just a few small notes.

  • There's some extra margin at the bottom of the list. It's visible when the list is scrollable.
image
  • As a suggestion (could be done in another PR), WDYT of showing the meatballs menu (the 3 dots) on hover similar to /sites? To make it even more consistent, we could rotate the dots vertically.
  • Another suggestion - it would be nice to have an active state for the selected domain in the sidebar (same as /sites).

}

// Similar to the sites-overview, hide the domains-overview list on the left on smaller screens.
@media (max-width: 1280px) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the previous comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing it in favor of this PR #97240

@Imran92
Copy link
Contributor Author

Imran92 commented Dec 11, 2024

There's some extra margin at the bottom of the list. It's visible when the list is scrollable.

I've removed the space here. Have also changed the scroll behavior to scroll including the search bar, to match the behavior of /sites.

As a suggestion (could be done in another PR), WDYT of showing the meatballs menu (the 3 dots) on hover similar to /sites? To make it even more consistent, we could rotate the dots vertically.

I've made the meatball menu vertical and show on hover as well.

Another suggestion - it would be nice to have an active state for the selected domain in the sidebar (same as /sites).

Good suggestion, but I've intentionally not done that yet, because the selected site determination process will change significantly with DataViews. So to avoid re-works, I think it'll be better to do it once we have the DataViews

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants