-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Domain management revamp: update domain list column styles in sidebar #97193
base: trunk
Are you sure you want to change the base?
Conversation
Jetpack Cloud live (direct link)
Automattic for Agencies live (direct link)
|
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~165 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
client/my-sites/domains/domain-management/domain-overview-pane/style.scss
Outdated
Show resolved
Hide resolved
} | ||
|
||
// Similar to the sites-overview, hide the domains-overview list on the left on smaller screens. | ||
@media (max-width: 1280px) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as the previous comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing it in favor of this PR #97240
I've removed the space here. Have also changed the scroll behavior to scroll including the search bar, to match the behavior of /sites.
I've made the meatball menu vertical and show on hover as well.
Good suggestion, but I've intentionally not done that yet, because the selected site determination process will change significantly with DataViews. So to avoid re-works, I think it'll be better to do it once we have the DataViews Thanks!! |
Related to #96554
Proposed Changes
Updates the looks of the left side of the Domains preview
Why are these changes being made?
Testing Instructions
Pre-merge Checklist