Sites dashboard: Clicking a site as non-admin leads to a broken flashing state

[fushar]

Quick summary

If I'm a non-admin of a site, and I click on that site from /sites, I'm supposed to get redirected to My Home immediately. However, I see a flashing screen of broken flyout panel.

Steps to reproduce

1. Invite a test user to a site as Contributor / Editor.
2. Log in as that user.
3. Go to /sites.
4. Click on that site.

What you expected to happen

I see My Home immediately.

What actually happened

I see a broken intermediate state:

Screen.Capture.on.2024-12-05.at.17-56-16.mp4

Impact

Some (< 50%)

Available workarounds?

There is no user impact

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

It's similar to https://github.com/Automattic/dotcom-forge/issues/7311.

I think it's a regression when we decouple the sites dashboard logic from A4A.

[github-actions]

OpenAI suggested the following labels for this issue:

• [Feature Group] User Management: The issue is related to how non-admin users interact with site access and permissions.
• [Feature] My Home: Since the issue revolves around the redirection to 'My Home' after clicking on a site, it's directly relevant.
• [Feature] Authentication: The problem may involve user authentication when non-admin users attempt to access restricted areas.

[supernovia]

I bumped into this while triaging The One Board. I'm setting this to In Progress; feel free to re-update the status if needed!

[okmttdhr]

Thanks for fixing this, @fushar 🙏