Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimise data transfer on /themes #95248

Open
niranjan-uma-shankar opened this issue Oct 9, 2024 · 2 comments · May be fixed by #96961
Open

Optimise data transfer on /themes #95248

niranjan-uma-shankar opened this issue Oct 9, 2024 · 2 comments · May be fixed by #96961
Assignees
@danluu @mmtr @xavier-lc
Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Enhancement [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com [Type] Performance

Comments

@niranjan-uma-shankar
Copy link
Contributor

Quick summary

The /themes page loads ~35MB of data on page load.

Steps to reproduce

  1. On Chrome, open dev tools, and keep the network tab open
  2. Visit /themes page
  3. Observe the data transferred over the network

What you expected to happen

Data transferred to be in the ballpark of 5MB, similar to the "Pick a design" step in the signup flow

What actually happened

Data transferred over the network is ~35MB. This is a significant amount of data to be transferring for a single page load. There was previously a related conversation on optimising the network transfer on "Pick a design" step in pdKhl6-3ds-p2. @danluu worked on image optimisations which led to a significant reduction in data transferred on this step. It would be great to apply that on the /themes page too.

This was discussed in p1728385843769819/1728381142.767659-slack-C02FMH4G8.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response
@niranjan-uma-shankar niranjan-uma-shankar added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug Needs triage Ticket needs to be triaged labels Oct 9, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Pri] High labels Oct 9, 2024
@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 10, 2024
@jartes jartes added [Type] Performance Triaged To be used when issues have been triaged. and removed Needs triage Ticket needs to be triaged labels Oct 10, 2024
@inaikem inaikem closed this as completed Oct 13, 2024
@inaikem inaikem reopened this Oct 13, 2024
@inaikem inaikem added [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com [Type] Enhancement and removed [Type] Bug labels Oct 29, 2024
@Copons
Copy link
Contributor

Copons commented Oct 29, 2024

@Automattic/t-rex I've dropped this on our board for a check. 35MB is pretty high for such a high-traffic screen. It could be a good opportunity for regular maintenance.

@xavier-lc
Copy link
Contributor

I'll give it a go

@xavier-lc xavier-lc self-assigned this Oct 30, 2024
This was referenced Oct 30, 2024
Merged
Closed
@mmtr mmtr moved this from Triaged to In Progress in Automattic Prioritization: The One Board ™ Nov 28, 2024
@mmtr mmtr self-assigned this Dec 2, 2024
@mmtr mmtr linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danluu danluu

@mmtr mmtr

@xavier-lc xavier-lc

Labels
[Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Theme Showcase The theme showcase screen in Calypso in Appearance > Themes. [Pri] High [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Enhancement [Type] Fit and Finish Issues related to the fit, finish and overall polish of WordPress.com [Type] Performance
Projects
Automattic Prioritization: The One Board ™
Status: In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Themes: Lazy load screenshots Automattic/wp-calypso
7 participants
@danluu @jartes @mmtr @niranjan-uma-shankar @Copons @xavier-lc @inaikem