Prototype: Move goals step to front of onboarding if onboarding/goals-first flag

[p-jackson]

Closes #96756

Proposed Changes

Uses an onboarding/goals-first feature flag to move the goals step to the very beginning of the onboarding flow. This PR allows you to prototype the change, but it is far from complete.

CleanShot.2024-11-28.at.21.02.46.mp4

Why are these changes being made?

We want to start moving more onboarding tasks in front of the paywall. This creates a skeleton of that change. Once this PR is merged—hidden behind a feature flag—we can add tasks for each of the TODOs I've left in the code and have multiple people working on it.

CC @Automattic/vertex this PR is adding a feature flag to the onboarding flow as mentioned here p1732691488986329-slack-C02T4NVL4JJ

Testing Instructions

• The prototype flow
  • Start at /setup/onboarding?flags=onboarding/goals-first
  • Confirm you can create a new site, however most of the branching is broken. To be completed in follow up PRs.
• The onboarding flow
  • This PR shouldn't have made any changes to the flow beginning at /setup/onboarding
  • It's not currently used by any users, but might be soon
• The production flow
  • Do not break the flow beginning at /start
  • This PR should not cause any changes to the main flow starting at /start
  • The main flow eventually lands in the site-setup stepper flow, that's the only place this might make unintentional changes to that flow.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126858

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126858&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-126858&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~5598 bytes added 📈 [gzipped])

name             parsed_size             gzip_size
onboarding-flow     +56754 B  (+314.5%)    +5379 B  (+86.3%)
site-setup-wg         +594 B    (+0.5%)     +219 B   (+0.9%)
site-setup-flow       +594 B    (+0.5%)     +219 B   (+0.9%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/add-goals-first-flag on your sandbox.

[candy02058912]

Tested and can access the Goals step in logged out state 👍
The original /start flow is not affected by the changes in this pr

[arthur791004]

hmmm...it seems the default value should be false on both dev and staging since it is far from complete and it changed the behavior after creating a new site with proxy...

[arthur791004]

Proposed #97219