Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load the breadcrumb component on top of the sub-pages #96832

Open
Imran92 opened this issue Nov 27, 2024 · 4 comments
Open

Load the breadcrumb component on top of the sub-pages #96832

Imran92 opened this issue Nov 27, 2024 · 4 comments
Assignees
Labels
[Experiment] AI labels added [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Customizer The site customizer for traditional, non-block themes. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Site Navigation

Comments

@Imran92
Copy link
Contributor

Imran92 commented Nov 27, 2024

The breadcrumb component is already there and is shown in different Calypso pages in admin panel. For example, Upgrades -> Domains, Upgrades -> Emails etc inner pages.

Every sub-page will show a breadcrumb component on top.

Image

Tasks

  1. Load the breadcrumb on top
  2. The area below should load any component passed by the context
@github-actions github-actions bot added [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Customizer The site customizer for traditional, non-block themes. labels Nov 27, 2024
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Appearance & Themes: The issue is related to the display and management of the breadcrumb component, which affects the appearance of the site.
  • [Feature] Site Navigation: The breadcrumb component is a key element of site navigation, allowing users to understand their location within the site structure.
  • [Feature] Calypso & wp-admin Navigation: This component is part of the navigation experience within the Calypso interface, improving user navigation in the admin panel.
  • [Feature] Customizer: Although primarily about middleware, the customization involved in the breadcrumb's placement can relate to the settings available in the customizer.

@Imran92
Copy link
Contributor Author

Imran92 commented Dec 10, 2024

@m1r0 I'm updating the Title to not mention middleware specifically. Feel free to just reuse the current breadcrumb component, or creating a middleware or any other way that seems most suitable.

@Imran92 Imran92 changed the title Load the breadcrumb component in a middleware Load the breadcrumb component on top of the sub-pages Dec 10, 2024
@m1r0
Copy link
Member

m1r0 commented Dec 11, 2024

Sounds good, thanks!

@m1r0
Copy link
Member

m1r0 commented Dec 11, 2024

It looks like we could reuse the DomainHeader/NavigationHeader component.

Do we have a sub-page ready where I can add the breadcrumbs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature] Calypso & wp-admin Navigation All navigation in Calypso and wp-admin, and the unified transitions between the two. [Feature] Customizer The site customizer for traditional, non-block themes. [Feature Group] Appearance & Themes Features related to the appearance of sites. [Feature] Site Navigation
Projects
None yet
Development

No branches or pull requests

2 participants