Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account Settings: Modals in account deletion flow have incorrect spacing #95610

Closed
matt-west opened this issue Oct 23, 2024 · 2 comments
Closed

Account Settings: Modals in account deletion flow have incorrect spacing #95610

matt-west opened this issue Oct 23, 2024 · 2 comments
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Needs triage Ticket needs to be triaged [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug

Comments

@matt-west
Copy link
Contributor

Quick summary

The modals shown in the account deletion flow have incorrect spacing to the right and bottom of the action buttons.

Image
Image

Steps to reproduce

  1. Go to Account Settings.
  2. Close the account.
  3. Note that both the "Are you sure?" and "Confirm account closure" modals have too much space around the actions.

What you expected to happen

The padding to the right and bottom of the action buttons should be 24px.

What actually happened

Incorrect padding.

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

No response

Logs or notes

No response
@matt-west matt-west added [Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. [Product] WordPress.com All features accessible on and related to WordPress.com. [Type] Bug Needs triage Ticket needs to be triaged labels Oct 23, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Pri] High Address as soon as possible after BLOCKER issues labels Oct 23, 2024
@matt-west matt-west changed the title Modals in account deletion flow have incorrect spacing Account Settings: Modals in account deletion flow have incorrect spacing Oct 23, 2024
@matt-west matt-west changed the title Account Settings: Modals in account deletion flow have incorrect spacing Account Settings: Modals in account deletion flow have incorrect spacing Oct 23, 2024
@jartes jartes added [Pri] Low Address when resources are available. and removed [Pri] High Address as soon as possible after BLOCKER issues labels Oct 24, 2024
@jartes jartes moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 24, 2024
@jartes
Copy link
Contributor

jartes commented Oct 24, 2024

📌 REPRODUCTION RESULTS

  • Could Not Replicate

📌 FINDINGS/SCREENSHOTS/VIDEO
I checked this with Firefox and Chrome, and it looks okay from my end:

Image

Image

📌 ACTIONS

  • Triaged
  • Closed as could not replicate (please reopen if the issue reoccurs)
  • Lowered priority from High to Low.

📌 Message to Author
👋🏻 @matt-west Are you still getting this incorrect spacing? Thank you!

@jartes jartes closed this as not planned Won't fix, can't repro, duplicate, stale Oct 24, 2024
@matt-west
Copy link
Contributor Author

@jartes Nope. Looks like it’s been fixed! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature Group] Other Infrastructure Miscellaneous infrastructure features and improvements on WordPress.com. [Feature] User & Account Settings (/me) Settings and tools for managing your WordPress.com user account. Needs triage Ticket needs to be triaged [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug
Projects
Automattic Prioritization: The One Board ™
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@matt-west @jartes