Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header Bar Login CTA link not working #95358

Closed
stronenv opened this issue Oct 14, 2024 · 12 comments
Closed

Header Bar Login CTA link not working #95358

stronenv opened this issue Oct 14, 2024 · 12 comments
Assignees
Labels
Needs triage Ticket needs to be triaged [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug When a feature is broken and / or not performing as intended

Comments

@stronenv
Copy link

Quick summary

The Login redirect link doesn't work in the Header Banner that shows the Login CTA for the first 24h after you've attached a domain to a simple site.

Steps to reproduce

  1. Set up a fresh simple site
  2. Launch it / attach a domain
  3. The "Is this your new site? Log in to activate admin features and dismiss this message" header bar should appear on the site
  4. Click Log in and follow the steps.
  5. You'll get redirected to a blank page on https://r-login.wordpress.com/remote-login.php?action=link&back=%2F
  6. Message is not dismissed.

What you expected to happen

Be able to log in, and the message to be dismissed.

I can log in to my account, so it would be good to have a way to dismiss the message from the Site Editor or Dashboard. It sounded like I would "find" that option in the WP Admin once I was signed it.

What actually happened

Got redirected to a blank page on https://r-login.wordpress.com/remote-login.php?action=link&back=%2F

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

If the above answer is "Yes...", outline the workaround.

No response

Platform (Simple and/or Atomic)

Simple

Logs or notes

No response

@stronenv stronenv added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Oct 14, 2024
@github-actions github-actions bot added [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues labels Oct 14, 2024
@supernovia
Copy link
Contributor

📌 REPRODUCTION RESULTS

  • Tested on Simple – Could not replicate -- could not see CTA bar at all

📌 FINDINGS/SCREENSHOTS/VIDEO
Image
Image

📌 ACTIONS

  • Triaged
  • Requested author feedback

📌 Message to Author
@stronenv I can't get the login header CTA to come up at all right now. If I'm logged in, I see the normal bar. If I'm logged out, I don't get a CTA. I tried with and without proxy. Are there other circumstances needed to see the CTA bar with login?

@supernovia supernovia moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Oct 15, 2024
@stronenv
Copy link
Author

stronenv commented Oct 15, 2024

Thanks for checking this out, @supernovia! The header bar is only visible within the first 24 hours after you connect a new domain.

I noticed I also upgraded the site to the Premium plan prior to adding the domain.

Here's the banner for reference:
Image

@jartes
Copy link
Contributor

jartes commented Oct 16, 2024

Thanks for the additional info, @stronenv

While I was able to get the banner, I'm getting redirected correctly:

Screen.Recording.on.2024-10-16.at.05-09-18.mp4

This is the full link:

https://wordpress.com/log-in?redirect_to=https%3A%2F%2Fr-login.wordpress.com%2Fremote-login.php%3Faction%3Dlink%26back%3Dhttps%253A%252F%252F0testdelete.blog%252F2024%252F10%252F16%252Fhello-world%252F

Are you still getting the link that is not working?

@stronenv
Copy link
Author

It was after login. I realize the naming of the issue wasn't the best description 🙃 But steps 4 and 5 in Steps to Reproduce above are where the issue happened.

Also, after you're logged in, the message should be dismissed. Did that happen on your end, @supernovia ?

@supernovia
Copy link
Contributor

@stronenv I don't see any message, whether I'm logged in or not. I added a new domain for the test and shared screenshots above.

@stronenv
Copy link
Author

Hmm. It's notoriously hard to debug this if we need to keep buying new domains every 24h 😅
Do you know if there's a URL parameter or cookie we could set to make it show up?

@supernovia
Copy link
Contributor

@stronenv I don't ... I'm wondering though, I bought the domain while logged in (of course), but had to log back out again to look for any messaging prompting me to log in. Does it matter how I logged out?

@stronenv
Copy link
Author

No, sorry. I don't know how the dynamics of that works.

@BogdanUngureanu BogdanUngureanu self-assigned this Oct 21, 2024
@BogdanUngureanu
Copy link
Contributor

@supernovia @stronenv I've managed to reproduce the issue. Initially I couldn't, but it seems that after you remove the Hello World post, the user is then redirected to https://r-login.wordpress.com/remote-login.php?action=link&back=%2F where they get a blank page.

I'll look into it. :)

@BogdanUngureanu BogdanUngureanu moved this from In Triage to In Progress in Automattic Prioritization: The One Board ™ Oct 21, 2024
@BogdanUngureanu BogdanUngureanu moved this from In Progress to Needs Review in Automattic Prioritization: The One Board ™ Oct 21, 2024
@BogdanUngureanu
Copy link
Contributor

Opened D164219-code that fixes the issue. :)

@BogdanUngureanu
Copy link
Contributor

Deployed it! @stronenv can you can confirm that the issue is not reproducing anymore? :)

@stronenv
Copy link
Author

Hi @BogdanUngureanu!

Yes, I can confirm that it works as expected now. I've tried with a new blog and a new domain, deleting the Hello World post, and I got redirected correctly after login. Thanks both for working on this 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs triage Ticket needs to be triaged [Platform] Simple [Pri] High Address as soon as possible after BLOCKER issues [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

4 participants