-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header Bar Login CTA link not working #95358
Comments
📌 REPRODUCTION RESULTS
📌 ACTIONS
📌 Message to Author |
Thanks for checking this out, @supernovia! The header bar is only visible within the first 24 hours after you connect a new domain. I noticed I also upgraded the site to the Premium plan prior to adding the domain. |
Thanks for the additional info, @stronenv While I was able to get the banner, I'm getting redirected correctly: Screen.Recording.on.2024-10-16.at.05-09-18.mp4This is the full link:
Are you still getting the link that is not working? |
It was after login. I realize the naming of the issue wasn't the best description 🙃 But steps 4 and 5 in Steps to Reproduce above are where the issue happened. Also, after you're logged in, the message should be dismissed. Did that happen on your end, @supernovia ? |
@stronenv I don't see any message, whether I'm logged in or not. I added a new domain for the test and shared screenshots above. |
Hmm. It's notoriously hard to debug this if we need to keep buying new domains every 24h 😅 |
@stronenv I don't ... I'm wondering though, I bought the domain while logged in (of course), but had to log back out again to look for any messaging prompting me to log in. Does it matter how I logged out? |
No, sorry. I don't know how the dynamics of that works. |
@supernovia @stronenv I've managed to reproduce the issue. Initially I couldn't, but it seems that after you remove the Hello World post, the user is then redirected to I'll look into it. :) |
Opened D164219-code that fixes the issue. :) |
Deployed it! @stronenv can you can confirm that the issue is not reproducing anymore? :) |
Hi @BogdanUngureanu! Yes, I can confirm that it works as expected now. I've tried with a new blog and a new domain, deleting the Hello World post, and I got redirected correctly after login. Thanks both for working on this 🙌 |
Quick summary
The Login redirect link doesn't work in the Header Banner that shows the Login CTA for the first 24h after you've attached a domain to a simple site.
Steps to reproduce
What you expected to happen
Be able to log in, and the message to be dismissed.
I can log in to my account, so it would be good to have a way to dismiss the message from the Site Editor or Dashboard. It sounded like I would "find" that option in the WP Admin once I was signed it.
What actually happened
Got redirected to a blank page on https://r-login.wordpress.com/remote-login.php?action=link&back=%2F
Impact
Some (< 50%)
Available workarounds?
No but the platform is still usable
If the above answer is "Yes...", outline the workaround.
No response
Platform (Simple and/or Atomic)
Simple
Logs or notes
No response
The text was updated successfully, but these errors were encountered: