Theme Showcase: Style variation incorrectly set

[dsas]

Quick summary

It's possible to choose the default (free) style variation, make no global styles changes and still have global styles upgrade nudges everywhere.

h/t @JanaMW27 for the original report (p1724264534878539-slack-C048CUFRGFQ)

Steps to reproduce

1. Be on a free site
2. Go to /themes
3. Click a style variation disc on the theme showcase grid
4. Click the default variation disc
5. Click into the theme
6. Activate it
7. Look at the front-end of the site, or the site editor

Screen.Recording.2024-08-22.at.18.33.30.mov

What you expected to happen

I should see my site using the default style variation and no global styles upgrade nudges.

What actually happened

I see global styles upgrades nudges in all the usual places.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

If the above answer is "Yes...", outline the workaround.

There are two workarounds:

1. Ignore the misleading upgrade nudges
2. Use the site editor, open the gs panel and reset global styles

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

Presumably selecting a style variation disc, even if it's the default means that the style variation is copied into the global styles CPT and so the upgrade nudge thinks there's a need to ugprade. Probably somewhere we need to check whether the selected style variation slug is default and not do this.

[retnonindya]

📌 REPRODUCTION RESULTS

• Tested on Simple – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
The live site displays upgrade nudge despite the style being used is the default style

📌 ACTIONS

• Triaged

[arthur791004]

Closing it by #95542