Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline / in-content images don't appear as thumbnails in Calypso post/page list #92033

Closed
eduardozulian opened this issue Jun 21, 2024 · 20 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Posts & Pages Lists The screens for seeing and managing all your pages and posts. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@eduardozulian
Copy link
Member

eduardozulian commented Jun 21, 2024

Quick summary

When you add an inline image to a post, that image does not appear in the post list next to the title in Calypso.

It started with a couple of reports in p2EDhh-2eU-p2 (we couldn't reproduce it) but I managed to replicate it on simple and AT sites.

  • The report above mentions that this could be related to using old themes, but I tested with at least two newer ones, including Twenty Twenty-Four.
  • There is a related issue in WebP images do not show in Calypso Posts/Pages list #91733, but that's apparently only for webp and includes features images.

The workaround for simple sites is to change to wp-admin.

Steps to reproduce

  1. Using Calypso, go to Posts
  2. Start a new post
  3. Add an inline image
  4. Publish the post

What you expected to happen

See the thumbnail right next to the post, just like we do with featured images.

What actually happened

In Calypso, the images aren't there on simple or Atomic sites:

Markup 2024-06-21 at 13 27 56

There's also an empty markup with no img src:

<a href="/post/eduardoistesting.blog/5144" class="post-type-list__post-thumbnail-link"><img class="post-type-list__post-thumbnail"></a>

image

For wp-admin they appear on simple sites:

Markup on 2024-06-21 at 13:29:29

But are missing from AT sites in wp-admin:

Markup on 2024-06-21 at 13:30:39

Impact

Most (> 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

Simple, Atomic

Logs or notes

No response

@eduardozulian eduardozulian added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Posts & Pages Lists The screens for seeing and managing all your pages and posts. labels Jun 21, 2024
@mdtanjid0
Copy link

Another user is facing the same issue: 8368017-zen

@ktyfuller604
Copy link

A user with both inline images and a featured image set has noticed the issue with their latest posts. Starting with a June 9th post.

8343414-zen

@mrfoxtalbot
Copy link

I cannot reproduce this @eduardozulian. Do you see any patterns that would help us reproduce this consistently? Maybe the image format or size?

@mrfoxtalbot mrfoxtalbot added the [Pri] Low Address when resources are available. label Jul 1, 2024
@mrfoxtalbot mrfoxtalbot moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Jul 1, 2024
@mrfoxtalbot
Copy link

@ktyfuller604, @eduardozulian, @mdtanjid0 I still cannot reproduce this.

Are you still able to reproduce it consistently?

@ktyfuller604
Copy link

I checked the example I had (8343414-zen). The newest post has a thumbnail in the list of posts, but none of their four June posts have a thumbnail. It looks partially resolved.

@mdtanjid0
Copy link

I have checked 8368017-zed and am still experiencing the same issue. It shows with the Classic view, but not with the default view. An example post ID (114122).

@eduardozulian
Copy link
Member Author

@mrfoxtalbot I have no extra info on why or how this is happening. I've tested with png and jpg but, but I'm aware it's being difficult to replicate. But the issue is still present on my end.

@mrfoxtalbot
Copy link

mrfoxtalbot commented Jul 17, 2024

I still cannot repro this in the post below :S

https://mrfoxtestingsite.wordpress.com/2024/07/01/inline-images-dont-appear-in-calypso-post-page-list-92033/

Featured Image is NOT set:
Screenshot 2024-07-17 at 17 40 59
But images show fine in Calypso and WP-Admin
Screenshot 2024-07-17 at 17 40 45
Screenshot 2024-07-17 at 17 40 39

@eduardozulian, could you add me the sites where you are seeing this so I can take a closer look? Thanks again!

@eduardozulian
Copy link
Member Author

@mrfoxtalbot, I added you as an editor to eduardoistesting.blog!

@zemirajput
Copy link

Another user is facing the same issue: 8546300-zen

Copy link

github-actions bot commented Aug 5, 2024

Support References

This comment is automatically generated. Please do not edit it.

  • 8368017-zen
  • 8343414-zen
  • 8546300-zen
  • 8638516-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Aug 5, 2024
@retnonindya retnonindya removed the Needs triage Ticket needs to be triaged label Aug 21, 2024
@eduardozulian
Copy link
Member Author

Another case: 8638516-zen

Simple site, custom domain, Premium plan. Inline images are only displayed in WP Admin.

@mrfoxtalbot
Copy link

Apologies for the belated triage @eduardozulian. I can confirm I am able to replicate this on your site and on my own site (simple site).

Screenshot 2024-08-27 at 19 07 40
Screenshot 2024-08-27 at 19 07 31

The reason I was confused is that I did NOT expect Calypso or WP-Admin to show inline images there. My understanding was that the thumbnail would only show actual featured images.

Are we 100% sure this box is indeed supposed to show featured images? @dsas, could you help us confirm/triage this?

Thanks!

@dsas
Copy link
Contributor

dsas commented Aug 28, 2024

It's supposed to show the post_thumbnail (featured image) or the first image in the content that is wider than 100px and where the width * height are at least 7500px (only works for jpegs, gifs and pngs)

It gets the thumbnail here which is set when the post is prepped for display.

The wp-admin logic is slightly different, if a featured image exists then it uses that otherwise it gets the first image that's from the media library (has a wp-image-ID class in html).

I quickly tested this on a testing site and couldn't reproduce, but whether it works depends upon the image dimensions, types and how it got into the post. @mrfoxtalbot / @eduardozulian could anything I've said explain what you're seeing?

@eduardozulian
Copy link
Member Author

@dsas, I don't think so. I see that every image is wider than 100px, and they go over 7500px (assuming I need to multiply height and width).

Here are the posts I shared in the first screenshot, plus the attached media, if you'd like to take a look:

Except for the first example, the other two images are pretty large.

@supernovia
Copy link
Contributor

Noting I just tested with a 4mb inline gif in case it was related to another issue, but I couldn't duplicate this even with large gifs and pasted images.

@tanjoymor
Copy link

I'm not able to reproduce this on several different test sites and accounts. However, I noticed that @eduardozulian test site was created in 2015. I found and tested another site created in 2015 and see the same issue on it. However, of the tickets reported in this issue, none of the site are that old and there is a mixture of variables.

8368017-zd-a8c - problem posts have images added in the Classic block

8343414-zd-a8c - problem posts are using webp

8546300-zd-a8c - no thumbnails at all since 2020, one example: JPEG 1699 ✕ 988 - Image Block

8638516-zd-a8c - (Blog ID 236084129) no thumbnails on posts since Aug 20th, one example: PNG 816 ✕ 1308 - Image Block

I wonder if the title of this issue should be updated, because none of these are using "inline" images as in this option:

Image

@eduardozulian eduardozulian changed the title Inline images don't appear in Calypso post/page list Inline / in-content images don't appear as thumbnails in Calypso post/page list Oct 9, 2024
@eduardozulian
Copy link
Member Author

@tanjoymor, good call. I was referring to adding an image as part of the content (in this case, simply adding an Image block), but I can see how this can be confused with the actual inline image option that I always forget about. Sorry for pointing you in the wrong direction!

I updated the reproduction steps to specify the Image block and the issue title. Feel free to update it again if needed!

@inaikem
Copy link
Contributor

inaikem commented Oct 15, 2024

Unable to reproduce consistently. It seems a number of factors contribute to the issue: Classic Block, WebP, and potentially image sizes. I suggest opening a 2EDhh-p2 post for wider HE review and suspect we'll deal with a lot of these issues through updated documentation vs technical fix.

Keeping this open for now.

Cc: @tanjoymor

@tanjoymor tanjoymor moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Oct 24, 2024
@tanjoymor tanjoymor added the Triaged To be used when issues have been triaged. label Oct 24, 2024
@tanjoymor
Copy link

Published a P2 post: p2EDhh-2mI-p2

Looking to gain a broader involvement from HEs to gather reports and do some testing to see if we can drill down on the different causes, as there seems to be a number of different reasons this happens.

Closing this issue for now, in favor of the P2. We can reopen this with more specifics once we're able to get a bit more specific clarity on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Posts & Pages Lists The screens for seeing and managing all your pages and posts. [Pri] Low Address when resources are available. [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

10 participants