Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue with Google: Fix failing E2E test #89008

Closed
ivan-ottinger opened this issue Mar 28, 2024 · 3 comments · Fixed by #89007
Closed

Continue with Google: Fix failing E2E test #89008

ivan-ottinger opened this issue Mar 28, 2024 · 3 comments · Fixed by #89007
Assignees

Comments

@ivan-ottinger
Copy link
Contributor

ivan-ottinger commented Mar 28, 2024

One of the tests related to Continue with Google button is failing.

Context: p1711559464401219-slack-C02DQP0FP.

@ivan-ottinger ivan-ottinger self-assigned this Mar 28, 2024
@ivan-ottinger ivan-ottinger changed the title Continue with Google: Fix failing test Continue with Google: Fix failing E2E test Mar 28, 2024
@ivan-ottinger
Copy link
Contributor Author

We were looking at the issue together with @mashikag and it turns out the test is failing because they tried to click the Continue with Google button before it became available (as it is waiting for the nonce to be generated).

@ivan-ottinger
Copy link
Contributor Author

Turns out the tests are still failing, on a different part this time:

 ✕ Enter 2FA challenge if required - Challenge 2 (30003 ms)

  ● Signup: WordPress.com WPCC > WooCommerce Via Google › Signup via /start/wpcc › Enter 2FA challenge if required - Challenge 2

    page.waitForEvent: Timeout 30000ms exceeded while waiting for event "close"
    =========================== logs ===========================
    waiting for event "close"
    ============================================================

      126 | 				}
      127 |
    > 128 | 				const googlePopupPageClosePromise = googlePopupPage.waitForEvent( 'close' );
          | 				                                                    ^
      129 |
      130 | 				// Wait until the TOTP code generated by the client
      131 | 				// changes, meaning the 30s window has rolled over.

      at Object.waitForEvent (specs/onboarding/signup__woo-google.ts:128:57)

Test Suites: 1 failed, 1 total
Tests:       1 failed, 1 skipped, 5 passed, 7 total
Snapshots:   0 total
Time:        72.595 s, estimated 73 s

→ I am reopening the issue.

@ivan-ottinger ivan-ottinger reopened this Mar 28, 2024
@ivan-ottinger
Copy link
Contributor Author

We have fixed the above issue in #89007.

However, there's one more broken test (unrelated to our changes). I have created a new issue for it: #89243

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants