Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stats: Use a ghost element for upsell background #88116

Closed
grzegorz-cp opened this issue Mar 3, 2024 · 1 comment
Closed

Stats: Use a ghost element for upsell background #88116

grzegorz-cp opened this issue Mar 3, 2024 · 1 comment
Labels
[Feature] Stats Everything related to our analytics product at /stats/

Comments

@grzegorz-cp
Copy link
Contributor

grzegorz-cp commented Mar 3, 2024 •
edited
Loading

Move the upsell overlay up to the stats-module-utm to avoid requesting data and displaying a static ghost loader under the blur layer.

Use conditional rendering to either render the ghost module or StatsModuleDataQuery.
@grzegorz-cp grzegorz-cp added the [Feature] Stats Everything related to our analytics product at /stats/ label Mar 3, 2024
@kangzj
Copy link
Contributor

kangzj commented Mar 19, 2024

fixed with #88629

@kangzj kangzj closed this as completed Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Stats Everything related to our analytics product at /stats/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kangzj @grzegorz-cp