Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using editor commands on sites with the Default view active results to a 404 redirection #86000

Closed
jimjasson opened this issue Jan 4, 2024 · 13 comments
Assignees
Labels
[Pri] BLOCKER Requires immediate attention. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jimjasson
Copy link

Quick summary

When the Default view is used for pages and someone creates a new page and uses CMD + K to navigate to "Single Posts", they they get redirected to a 404 page.

Steps to reproduce

  1. Set up a new Creator site.
  2. Navigate to the Pages tab.
  3. Select the Default View.
  4. Create a new page.
  5. Click CMD + K.
  6. Select "Single Posts".
  7. See the 404 error.

What you expected to happen

I expect to be redirected to the template as expected.

What actually happened

I am redirected to a 404 page.

Impact

All

Available workarounds?

No and the platform is unusable

Platform (Simple and/or Atomic)

No response

Logs or notes

I can replicate this issue both on Creator and Woo Express sites.

Here's a short video:

T6wZRV.mp4
@jimjasson jimjasson added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Jan 4, 2024
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jan 4, 2024
@github-actions github-actions bot added the [Pri] BLOCKER Requires immediate attention. label Jan 4, 2024
@rickmgithub rickmgithub added [Pri] Normal Schedule for the next available opportuinity. Triaged To be used when issues have been triaged. and removed [Pri] BLOCKER Requires immediate attention. Needs triage Ticket needs to be triaged labels Jan 5, 2024
@rickmgithub rickmgithub moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Jan 5, 2024
@matticbot matticbot moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Jan 5, 2024
@rickmgithub
Copy link

📌 REPRODUCTION RESULTS

VIDEO:
Please see video provided by OP

STEPS TO REPLICATE

  • Set up a new Creator site.

  • Navigate to the Pages tab.

  • Select the Default View.

  • Create a new page.

  • Select blank template

  • Click CMD + K.

  • Select "Single Posts".

  • Get the "refused to connect" error.

  • Tested on Simple – Replicated

  • Tested on Atomic – Replicated

📌 ACTIONS

Triaged

@jeroenpf jeroenpf self-assigned this Jan 5, 2024
@jeroenpf jeroenpf removed their assignment Mar 22, 2024
@lsl
Copy link
Contributor

lsl commented Aug 26, 2024

The nested iframe isn't able to navigate the top level page, we need the URL to be swapped with a wpcom one similar to what we do for other wp-admin urls:

const manageReusableBlocksAnchorElem = popoverSlot.querySelector(
'a[href$="site-editor.php?path=%2Fpatterns"]'
);
const manageNavigationMenusAnchorElem = popoverSlot.querySelector(
'a[href$="edit.php?post_type=wp_navigation"]'

@inaikem inaikem closed this as completed Oct 13, 2024
@inaikem inaikem reopened this Oct 13, 2024
@inaikem inaikem moved this from Done 🎉 to In Progress in Automattic Prioritization: The One Board ™ Oct 15, 2024
@inaikem inaikem moved this from In Progress to Triaged in Automattic Prioritization: The One Board ™ Oct 15, 2024
@inaikem inaikem added [Pri] BLOCKER Requires immediate attention. and removed [Pri] Normal Schedule for the next available opportuinity. labels Oct 15, 2024
@inaikem
Copy link
Contributor

inaikem commented Oct 15, 2024

@mmtr 👍

@obenland
Copy link
Member

@inaikem @mmtr What's the status on this? Why is this a blocker?

@lsl lsl removed the [Pri] BLOCKER Requires immediate attention. label Oct 22, 2024
@lsl
Copy link
Contributor

lsl commented Oct 22, 2024

Not a blocker. High maybe. Was hoping this would have been fixed by the editor iframe removal by now 😬

@mmtr
Copy link
Member

mmtr commented Oct 22, 2024

What's the status on this?

@xavier-lc was working on a fix and already merged, but don't know if's been shipped. Xavier, can you confirm?

Why is this a blocker?

@ianstewart flagged it as a blocker on the last Dotcom Triage Group session. Every navigation issue (i.e. you click on something and you don't land on the expected place), including commands from the command palette, should be considered critical issues.

@mmtr mmtr added the [Pri] BLOCKER Requires immediate attention. label Oct 22, 2024
@matticbot matticbot moved this from In Progress to Triaged in Automattic Prioritization: The One Board ™ Oct 22, 2024
@mmtr
Copy link
Member

mmtr commented Oct 22, 2024

Looks like @xavier-lc forgot to deploy the changes, and @lsl did that today (D164295-code), so we can close this one out.

@lsl
Copy link
Contributor

lsl commented Oct 22, 2024

I was still seeing this in production after deploying that change. Maybe a Firefox only issue now or something?

@xavier-lc
Copy link
Contributor

Tha nks for the deploy, @lsl. With I was still seeing this in production after deploying that change you mean you can still reproduce the error? I've just checked on brave and firefox and it worked.

@lsl
Copy link
Contributor

lsl commented Oct 22, 2024

Yes. Might be a browser cache/setting, can't repro on mobile. Will look into it more tomorrow.

@mmtr
Copy link
Member

mmtr commented Oct 22, 2024

@lsl note that the wpcom-block-editor scripts are cached for 24h, so you might still be loading the old ones.

@xavier-lc
Copy link
Contributor

I've found that pressing the ENTER key on the commands wasn't working properly, here's the fix: #95575

@lsl
Copy link
Contributor

lsl commented Oct 23, 2024

so you might still be loading the old ones.

I invalidated those, p1729574805314119/1729487009.644859-slack-CRWCHQGUB I think I must have been using the enter key 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] BLOCKER Requires immediate attention. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug When a feature is broken and / or not performing as intended
Development

No branches or pull requests

8 participants