Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment likes being "lost" after refresh in Reader #85276

Closed
daledupreez opened this issue Dec 14, 2023 · 3 comments
Closed

Comment likes being "lost" after refresh in Reader #85276

daledupreez opened this issue Dec 14, 2023 · 3 comments
Labels
[Feature Group] User Interaction & Engagement Tools and features for site owners to share, promote, and manage engagement with their audiences. [Feature] Reader The reader site on Calypso. [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug

Comments

@daledupreez
Copy link
Contributor

Quick summary

As reported in p1702541010734839-slack-CBG1CP4EN, we have a user reporting an issue where liking a comment in the Reader and then refreshing the page causes the like to disappear.

The behaviour seems very similar to #84213, which was a very similar behaviour for posts in the Reader that we addressed a few weeks ago.

Steps to reproduce

  1. Visit a feed in the Reader where one or more posts have comments
  2. Like a comment and then refresh the page.

You may need to throttle your network connection to make it easier to reproduce.

What you expected to happen

The comment should show as liked by the current user after the refresh.

What actually happened

The comment doesn't always show as liked after the refresh.

Impact

Some (< 50%)

Available workarounds?

Yes, easy to implement

Platform (Simple and/or Atomic)

No response

Logs or notes

I took a quick look at this as I worked on the previous issue with likes for Reader posts, and it looks like we have a related issue to do with client-side state.

When I took a look at https://github.com/Automattic/wp-calypso/blob/6c2c5f9e3bd92a81a4b926161ae7032e6e31064b/client/state/data-layer/wpcom/sites/comments/likes/new/index.js, it seems like we're only updating the client-side state after we get the response back from the server. If that's true, it would be more user-friendly to optimistically update the client-side state and roll the update back if there was an error.

@daledupreez daledupreez added [Type] Bug [Feature] Reader The reader site on Calypso. Needs triage Ticket needs to be triaged [Product] WordPress.com All features accessible on and related to WordPress.com. [Feature Group] User Interaction & Engagement Tools and features for site owners to share, promote, and manage engagement with their audiences. labels Dec 14, 2023
@daledupreez daledupreez moved this from Needs Triage to Triaged in Automattic Prioritization: The One Board ™ Dec 14, 2023
@daledupreez daledupreez added Triaged To be used when issues have been triaged. [Pri] Normal Schedule for the next available opportuinity. and removed Needs triage Ticket needs to be triaged labels Dec 14, 2023
@markbiek
Copy link
Contributor

I'm not able to reproduce this any more, even throttling my connection.

Do we know if we're still getting reports of this issue?

@sixhours
Copy link
Contributor

sixhours commented Feb 5, 2024

I've also been unable to reproduce this FWIW.

@sixhours
Copy link
Contributor

Since two of us can't reproduce this and we're unlikely to work on Reader enhnancements soon, I'm going to close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature Group] User Interaction & Engagement Tools and features for site owners to share, promote, and manage engagement with their audiences. [Feature] Reader The reader site on Calypso. [Pri] Normal Schedule for the next available opportuinity. [Product] WordPress.com All features accessible on and related to WordPress.com. Triaged To be used when issues have been triaged. [Type] Bug
Development

No branches or pull requests

3 participants