Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☂️ Jetpack Google Fonts module with the new Font Library #82226

Closed
23 tasks done
arthur791004 opened this issue Sep 27, 2023 · 7 comments
Closed
23 tasks done

☂️ Jetpack Google Fonts module with the new Font Library #82226

arthur791004 opened this issue Sep 27, 2023 · 7 comments
Assignees
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".

Comments

@arthur791004
Copy link
Contributor

arthur791004 commented Sep 27, 2023

Referring to #81875, we finished the spike and are familiar with the new Font Library and how to integrate the Jetpack Google Fonts module with it now (pbxlJb-4yR-p2). We'll continue to finish the integration and support the new Font Library.

Tasks

  • The Jetpack Google Fonts module can display the Google Fonts in the Site Editor correctly with the Gutenberg v16.7 above.
  • The Jetpack Google Fonts module still works well when the Gutenberg plugin is inactive
  • The homepage can render the text using Google Fonts correctly
  • The Font Library UI in the Editor keeps invisible on simple sites.
  • https://github.com/Automattic/dotcom-forge/issues/4535
  • Enable the Font Library on simple sites
  • Enable the Font Library on atomic sites

Advance

  • Load the Google Fonts on demand instead of all. As the discussion, this would be handled by Core. See pbxlJb-4yR-p2#comment-3049.

PRs

References

@arthur791004 arthur791004 self-assigned this Sep 27, 2023
@autumnfjeld
Copy link
Contributor

Waiting for Font Library on core to be released. Next release of Jetpack Nov 3 or 4.

@simison
Copy link
Member

simison commented Nov 9, 2023

@autumnfjeld @arthur791004 I enabled font module yesterday for Atomic sites as otherwise we saw fatals across few themes.

https://github.com/Automattic/wpcomsh/pull/1544

Atomic sites got Jetpack, WP 6.4 and Gutenberg 16.9 upgrades before this so should be safe from what I gather.

Copy link

github-actions bot commented Nov 9, 2023

Support References

This comment is automatically generated. Please do not edit it.

  • pbxlJb-4yR-p2#comment-3049

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Nov 9, 2023
@simison
Copy link
Member

simison commented Nov 10, 2023

@autumnfjeld @arthur791004 folks reverted the new font library enable PR, and applied another (temporary!) fix I suggested.

@autumnfjeld
Copy link
Contributor

Arthur has been AFK this week. I was in transit to Munich. Sorry we missed this.

@arthur791004
Copy link
Contributor Author

There is an issue related to enabling the new Font Library on the existing atomic sites. However, we cannot reproduce the issue, and we guess the issue might be the dirty data that is stored in the user's global styles... See https://github.com/Automattic/dotcom-forge/issues/4535#issuecomment-1809766836.

@okmttdhr okmttdhr changed the title Jetpack Google Fonts module with the new Font Library ☂️ Jetpack Google Fonts module with the new Font Library Dec 12, 2023
@arthur791004
Copy link
Contributor Author

Closing it as it's completed 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request".
Projects
None yet
Development

No branches or pull requests

3 participants