Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psychedeli: add theme #8513

Merged
merged 8 commits into from
Dec 13, 2024
Merged

Psychedeli: add theme #8513

merged 8 commits into from
Dec 13, 2024

Conversation

henriqueiamarino
Copy link
Collaborator

@henriqueiamarino henriqueiamarino commented Dec 9, 2024

PsycheDeli is the ultimate WordPress theme for bloggers and artists seeking to showcase their vibrant journeys through the captivating visuals of the '60s. Designed with passion and creativity, PsycheDeli is your gateway to effortlessly share your psychedelic adventures and thought-provoking creations with the world. Get ready to ignite imaginations and captivate audiences like never before with PsycheDeli.

Demo site | Content Export

screenshot

@henriqueiamarino henriqueiamarino added the Ready to launch Add this label if this is the first PR for a new theme label Dec 9, 2024
@henriqueiamarino henriqueiamarino self-assigned this Dec 9, 2024
@henriqueiamarino henriqueiamarino mentioned this pull request Dec 9, 2024
Copy link
Contributor

github-actions bot commented Dec 9, 2024

Preview changes

I've detected changes to the following themes in this PR: Psychedeli.
You can preview these changes by following the links below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@iamtakashi iamtakashi self-assigned this Dec 10, 2024
@iamtakashi
Copy link
Contributor

iamtakashi commented Dec 11, 2024

@henriqueiamarino here are my notes. Let me know if I can clarify anything further.

  • For all the featured images inside a cover block for the circle effect, it'd be better to set the width with % (leave the height blank) rather than an absolute px value to avoid looking like this on small screens.
    CleanShot 2024-12-10 at 18 55 08@2x
    CleanShot 2024-12-10 at 19 25 27@2x
  • It'd be better to set the border radius with % rather than an absolute value to avoid looking like this. 50% would make it a circle regardless of the size of the featured image.
    CleanShot 2024-12-10 at 19 00 16@2x
  • There is a left padding accidentally in the first cover block in the blog home template, so the feature image inside isn't the centre.
    CleanShot 2024-12-10 at 18 48 54@2x
  • Same as the last few themes, let's use the Jetpack Subscribe block for the subscription.
    CleanShot 2024-12-10 at 19 11 10@2x
  • I wonder if the posts in the article section on the home page can look similar or the same as the ones in the archives template because those look nicer to me.
    CleanShot 2024-12-10 at 19 14 46@2x
    CleanShot 2024-12-10 at 19 18 42@2x
  • It's subjective, but I didn't expect the navigation has a white background. It could have the yellow background.
    CleanShot 2024-12-10 at 19 32 25@2x
  • I know these are meant to be changed, but I'm unsure if Github and Linkedin are good defaults for the hypothetical profile. Tumblr and something else might be better.
  • The pullquote block seems a little too large compared to the body text. Could it be the medium size?
    CleanShot 2024-12-10 at 19 59 33@2x
  • In all the templates except Blog Home template, the gradient used in the "content" group doesn't change with the style variations. The group block doesn't have the gradient slug. I think you can fix it by reapplying the gradient in the editor and saving the templates again.
    CleanShot 2024-12-10 at 23 03 49@2x
  • Since the image path of the psychedelic flower background needs to be localised, the header-home and the header template parts need to be patterns. I can see they exist as patterns, but each of the template part file doesn't have the call to it. Like the parts/footer.html, they should have a call to their patterns. For example, the parts/header-home.html should only have <!-- wp:pattern {"slug":"psychedeli/header-home"} /-->.
  • main tag is missing in the Blog Home template. It makes sense if the "static content" group has it, but we probably should rename it just "content" since it's not static.
  • Let's change the version of the minimum PHP version to 7.0. in readme.txt.
  • There are lots of images are listed in readme.txt Let's only list the images bundled and seen in screenshot.png. But we need to change the three images from Pexels in screenshot.png because they aren't CC0 (more info). I find the most images in Pexel aren't compatible with GPL.
  • Let's change the version of the minimum PHP version to 7.0. in style.css
  • There are a number of numeric font sizes in theme.json. (site-title, h1, h2, and h3.) Can all be presets to provide a better customising experience?
  • Use only allowed theme tags. They should all be lower case and have no spaces. (e.g. Two Columns > two-colums) I don't think the following tags are appropriate for this theme. Entertainment, Portfolio, Three Columns, Editor Style, flexible-header, Site Editor, Full Width Template, Template Editing, Theme Options.
  • Instead the should have the following tags block-stylesand full-site-editing.
  • When a theme is ready to export, it's good idea to run the theme check with the plugin. It tells you if there is a problem with the theme tags.

@henriqueiamarino
Copy link
Collaborator Author

Thanks, @iamtakashi. I knew this would not be easy to fix, so I left it as the last one.
I followed and fixed all the issues you mentioned. But as you can see from the working theme on the demo site, we still have problems showing the background image on

and .

  • Set cover widths and corners to % for all Featured images inside all cover blocks;
  • Removing left padding from the first cover block on the Home template;
  • Replaced Jetpack block for as indicated;
  • Made all QL posts the same as we have for the Archive, Search, and Index templates;
  • Added Base color as the background color of the Navigation for and ;
  • Replaced social links as mentioned;
  • Fixed Pullquote block size;
  • Fixed the Content block for all templates, using the one from Blog Home, which was working well;
  • Followed instructions to make and patterns by fixing the HTML files on parts — not sure if this went well as the background image is not showing on the demo site;
  • Checked all tags again;
  • Minimum or Required PHP version set to 7.0 on readme.text and style.css;
  • Replaced all(?) the numeric font sizes mentioned;
  • Fixed tags following indications.

Before wrapping up this review, I'll wait for your thoughts on the background issue.

@iamtakashi
Copy link
Contributor

I've just pushed changes to the header and the header home template parts. After pulling my changes, can you test it?

I'll review the rest of your updates from now.

@iamtakashi
Copy link
Contributor

@henriqueiamarino, the only things that need to change again are;

  • Swapping the Jetpack Form block with the Subscription block.
  • The theme tags. There are some tags with spaces and capital letters. I think these are good to have for this theme blog, one-column, two-columns, block-styles, featured-images, full-site-editing, rtl-language-support, sticky-post, style-variations, threaded-comments, translation-ready, wide-blocks

@henriqueiamarino
Copy link
Collaborator Author

Thanks again, @iamtakashi. I will work on the demo site and the showcase page before submitting it tomorrow. As soon as I finish, I'll update the content export here and let you know.

Copy link
Contributor

Theme-Check results

psychedeli: No changes required ✅.


@iamtakashi
Copy link
Contributor

Ok, I'll ship it! 🚢

@iamtakashi iamtakashi merged commit a2d7284 into trunk Dec 13, 2024
3 checks passed
@iamtakashi iamtakashi deleted the add/psychedeli branch December 13, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to launch Add this label if this is the first PR for a new theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants