Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Amulet Theme's primary menu on mobile sits against edge of viewport. No margin or padding #7572

Open
Brianmitchtay opened this issue Dec 20, 2023 · 5 comments
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Plugin] WooCommerce [Pri] Normal Triaged [Type] Bug Something isn't working Woo Express

Comments

@Brianmitchtay
Copy link

Quick summary

We have a user in 7439836-zd-a8c that is using the amulet theme and is frustrated by some of the built-in styles, specifically the spacing on mobile and how in some cases the text has no margin between it and the edge of the viewport.

Is this an intentional design choice? Or should we move to have some padding added here? I'm inclined to agree with the user that it seems off. I've tried modifying the styling with CSS but have been unable to find a fix.

See screen recording below

Screen.Recording.2023-12-20.at.3.51.18.PM.mov

Steps to reproduce

Create an AT site
Install Amulet Theme
Inspect page to view with a mobile screen size
Open the primary navigation menu
Note the lack of padding or margin

What you expected to happen

The menu items on mobile shouldn't be right against the edge of the viewport with no padding

What actually happened

Screenshot 2023-12-20 at 3 54 13 PM

Browser

No response

Context

Customer reported in 7439836-zen

Platform (Simple, Atomic, or both?)

Atomic

Other notes

No response

Reproducibility

Consistent

Severity

All

Available workarounds?

Yes, difficult to implement

Workaround details

There is likely a way to modify this with CSS but I've not been able to target it effectively yet.

Copy link
Contributor

Support References

This comment is automatically generated. Please do not edit it.

  • 7439836-zen

@github-actions github-actions bot added the Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". label Dec 20, 2023
@kdingsa8c
Copy link

The following CSS appears to resolve this issue:
ref: 7439836-zen

.wp-block-navigation__responsive-close {
    width: 85%;
}

@Brianmitchtay
Copy link
Author

Brianmitchtay commented Dec 24, 2023

User has replied with a series of screenshots showing many places on the site where text is pressed right against the viewport edge on mobile.

These shared areas can all be edited in their respective templates via the site editor, however if we decide to add some padding natively to the theme a preferable solution here would be some theme-wide styling for a small amount of horizontal padding for text and elements on mobile views.

amulet-Screenshot_2023-12-22-22-31-25-086_com android chrome
amulet-Screenshot_2023-12-22-22-30-45-159_com android chrome
amuletScreenshot_2023-12-22-22-31-02-874_com android chrome
amulet-Screenshot_2023-12-22-22-30-27-522_com android chrome

@liviopv
Copy link

liviopv commented Dec 28, 2023

📌 REPRODUCTION RESULTS

  • Tested on Atomic – Replicated

📌 FINDINGS/SCREENSHOTS/VIDEO
From Amulet demo site:

CleanShot 2023-12-28 at 13 20 46@2x

CleanShot 2023-12-28 at 13 21 01@2x

Tsubaki for comparison:

CleanShot 2023-12-28 at 13 21 32@2x

📌 ACTIONS

  • Triaged

📌 Message to Author
@Brianmitchtay I have a hunch that this could be intentional. Pinging @alaczek to confirm.

As a workaround, you can define a custom padding globally from Global Styles:

CleanShot 2023-12-28 at 13 23 49@2x

@mmtr
Copy link
Member

mmtr commented Dec 10, 2024

I don't think the lack of padding is intentional according to original design visible in p9Jlb4-64U-p2:

Image

The issue also affects the demo site (https://amuletdemo.wpcomstaging.com/):

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Plugin] WooCommerce [Pri] Normal Triaged [Type] Bug Something isn't working Woo Express
Projects
Development

No branches or pull requests

4 participants