Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading error message on bad exec payload from flag #54

Open
eyal-mor opened this issue Feb 27, 2023 · 0 comments
Open

Misleading error message on bad exec payload from flag #54

eyal-mor opened this issue Feb 27, 2023 · 0 comments
Labels
bug Something isn't working DevX Developer Experience related exec Related to "shore exec"

Comments

@eyal-mor
Copy link
Contributor

Original Author: @slonokot

Running shore exec with bad JSON payload will produce misleading error message:

$ shore exec -p '{"application": "a", "pipeline": "b",,,}'
required args key 'pipeline' missing
required args key 'application' missing
$ shore exec -p '{"application": "a", "pipeline": "b}'
required args key 'pipeline' missing
required args key 'application' missing
$ shore exec -p '{"application": "a", "pipeline": "b", "parameters":}'
required args key 'pipeline' missing
required args key 'application' missing

The expected behaviour simillar to shore render's one:

"While parsing config: unexpected end of JSON input"

@dkirillov dkirillov added bug Something isn't working DevX Developer Experience related exec Related to "shore exec" labels May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working DevX Developer Experience related exec Related to "shore exec"
Projects
None yet
Development

No branches or pull requests

2 participants