Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement Request]: Standard Surface implementation #6

Open
PotatoPot6676 opened this issue Dec 2, 2022 · 2 comments
Open

[Enhancement Request]: Standard Surface implementation #6

PotatoPot6676 opened this issue Dec 2, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@PotatoPot6676
Copy link

Hey,

Thanks a lot for opening up the code 😄 I'm very grateful as it a very useful reference on how one can implement the Autodesk Standard Surface model. Such an implement of a multi-lobed BSDF model is hard to find online.

Looking through the code, it appears Aurora's implementation of the Standard Surface model diverges from the specification as well as Arnold in some key places like:

  1. Delta distribution is used for transmission rather than GGX. As a result, rough transmission for glass isn't supported.
  2. Volumetric properties aren't handled yet. It would be useful for absorption/scattering as well as brute force SSS.
  3. Subsurface uses diffuse transmission even if the thin walled property is false (The spec doesn't actually specify a model to be used though)

The readme says "..new features and enhancements to performance and quality planned" so my questions would be:

  1. Are there any plans to bring the material model closer to how its implemented in Arnold?
  2. Is there a list of planned features/enhancements that can be openly shared with the community?

Thank you.

@pixnblox
Copy link
Contributor

pixnblox commented Dec 3, 2022

Thanks for reaching out.

  1. YES, we do plan to improve the Standard Surface implementation. What we have now was deemed sufficient for our current needs, but is by no means a final state.
  2. We also have a fairly extensive list of features / tasks / issues tracked internally, and there was no easy way to share that publicly. Instead we will probably just list some highlights, maybe on the site wiki so we can keep it updated independent of the code.

We'll leave this issue open until we get that list together.

@PotatoPot6676
Copy link
Author

Thanks for your response. That cleared things up :)

@pixnblox pixnblox added the enhancement New feature or request label Dec 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants