Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checking for removed layers #290

Open
djtfmartin opened this issue Mar 22, 2021 · 0 comments
Open

Checking for removed layers #290

djtfmartin opened this issue Mar 22, 2021 · 0 comments
Labels
enhancement New feature or request low-priority pipelines Issue related to pipelines

Comments

@djtfmartin
Copy link
Member

djtfmartin commented Mar 22, 2021

We currently don't check for layers that have been removed from system.
This could mean the sample cache stored in HDFS at a dataset level or for all datasets continues to have layers in it that are no longer required making indexes bigger than necessary.
The remedy for this currently is to delete the sample cache manually (we could this an option to the Jenkins job).

To implement this, we will need to store a listing of the layers in sampling service and check against the service for changes.
A better solution might be to support soft deletes in the layers service. This is done to an extent already with the enabled flag, but there is no associated timestamp so there isn't a way of determining when a layer was deleted.

As the removal of layers isn't something that is that frequent, this is probably low priority.

@djtfmartin djtfmartin added the effort-low Estimated to require small amount of effort label Mar 22, 2021
@djtfmartin djtfmartin added the enhancement New feature or request label Apr 14, 2021
@djtfmartin djtfmartin added the post-v1.1 Not required for version 1 or v1.1 release label Apr 26, 2021
@javier-molina javier-molina added pipelines Issue related to pipelines low-priority and removed post-v1.1 Not required for version 1 or v1.1 release effort-low Estimated to require small amount of effort labels Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority pipelines Issue related to pipelines
Projects
None yet
Development

No branches or pull requests

2 participants