Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Command.Run() should correctly escape arguments #15

Closed
AshleighAdams opened this issue Mar 4, 2021 · 1 comment · Fixed by #16
Closed

Command.Run() should correctly escape arguments #15

AshleighAdams opened this issue Mar 4, 2021 · 1 comment · Fixed by #16
Labels
bug Something isn't working
Milestone
1.1

Comments

@AshleighAdams
Copy link
Owner

Currently as it stands, separate arguments passed into Command.Run() are concatenated together by space only.

Both spaces, quotes, and all other special chars should be escaped.
@AshleighAdams AshleighAdams added the bug Something isn't working label Mar 4, 2021
@AshleighAdams AshleighAdams added this to the 1.1 milestone Mar 4, 2021
@AshleighAdams
Copy link
Owner Author

Note that this should be fixed before or with #6.

AshleighAdams added a commit that referenced this issue Mar 14, 2021
@AshleighAdams
Added integration test to catch bug #15
59cf2b7
AshleighAdams added a commit that referenced this issue Mar 14, 2021
@AshleighAdams
Fixed Command.Run() not correctly escaping arguments
d93249d 
Fixes #15
@AshleighAdams AshleighAdams linked a pull request Mar 14, 2021 that will close this issue
Fix Command.Run() not escaping arguments correctly #16
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.1
Development

Successfully merging a pull request may close this issue.

Fix Command.Run() not escaping arguments correctly AshleighAdams/Verlite
1 participant
@AshleighAdams