Skip to content
This repository was archived by the owner on Dec 31, 2021. It is now read-only.

Pull requests actions #14

Open
7 of 12 tasks
Ash258 opened this issue Jun 25, 2019 · 10 comments
Open
7 of 12 tasks

Pull requests actions #14

Ash258 opened this issue Jun 25, 2019 · 10 comments
Assignees
Milestone

Comments

@Ash258
Copy link
Owner

Ash258 commented Jun 25, 2019

Triggers

  • Opened PR
  • Opened PR from fork
  • Comment❓❓
    • Anyone could comment to trigger this action
    • When PR is updated, then anyone could comment something like: /verify to trigger action again
  • Cleanup Test-PRFile function
    • Export checks into own funciton with $status, $manfiestOb, $manifestGci

Checks

  1. Description
  2. License (Add note to children list, about what is wrong)
    • License property exists, but it is not valid SPDX identifier
  3. Hashes
  4. Checkver
  5. Autoupdate
  6. Install (Install/Uninstall manifest PR check #59)
  7. Format (Format manifest check for PR #24)

Expected comment:

Thanks for contributing. Your PR did not pass requirements.

### Manifest 1

- [x] Description
- [ ] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate

### Manifest 2

- [x] Description
- [x] License
- [x] Hashes
- [x] Checkver
- [x] Autoupdate
Thanks for contributing. PR looks good.

Wait for review from human collaborators.

Implementation:

Best possible to temporary save into some hashtable:

@{name = 'Manifest1'; 'Checkver' = Passed; 'Properties': 'OK | list of failed properties'}

@Ash258 Ash258 self-assigned this Jun 25, 2019
@Ash258 Ash258 added this to the 1.0.0 Release milestone Jun 25, 2019
@Ash258 Ash258 added the enhancement New feature or request label Jun 25, 2019
@Ash258
Copy link
Owner Author

Ash258 commented Jun 26, 2019

Rework test-hash function to be reusable.

There is no need to do it this hard way. Keep it capturing streams and wait for binaries rework

@Ash258
Copy link
Owner Author

Ash258 commented Jun 26, 2019

Resolve how to run tests in context of pull request files

DONE

@Ash258
Copy link
Owner Author

Ash258 commented Jun 26, 2019

Try PR from forked repository

DONE

@Ash258
Copy link
Owner Author

Ash258 commented Jun 26, 2019

Basic implementation is done.

Now comes more problematic things:

- Install check
- Format check

Issue description

@Ash258
Copy link
Owner Author

Ash258 commented Jun 28, 2019

When invoking from forked repository, context is on current repository not forked.

Investigate how to do it with push event

Rather do it with custom cloning forked repository

@Ash258
Copy link
Owner Author

Ash258 commented Jun 28, 2019

Add more license checks:

- [x] If property exists
- [ ] If it is valid spdx identifier
- [ ] No? Is there URL?

md~~ ~~- [ ] License~~ ~~- [ ] Valid SPDX Identifier~~ ~~- [ ] Invalid + URL~~ ~~

This will require adding $Indent switch to create-new-checklist function

#21

@Ash258
Copy link
Owner Author

Ash258 commented Jun 28, 2019

Add note about log:

Please see run log for pure result of all checks

@Ash258
Copy link
Owner Author

Ash258 commented Jul 6, 2019

Forked repositories are now covered and working.

@Ash258
Copy link
Owner Author

Ash258 commented Jul 7, 2019

Pull request comments with /verify are handled

@Ash258
Copy link
Owner Author

Ash258 commented Jul 7, 2019

For first release this is enough.

Install and format will come in future versions

@Ash258 Ash258 removed this from the 1.0.0 Release milestone Jul 7, 2019
@Ash258 Ash258 added this to the 1.5.0 milestone Dec 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant