Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance information #3

Open
rande opened this issue Dec 17, 2014 · 3 comments
Open

Performance information #3

rande opened this issue Dec 17, 2014 · 3 comments

Comments

@rande
Copy link

rande commented Dec 17, 2014

Can you add more information about the gain of using this bundle ?

Thanks

@xavierlacot
Copy link
Contributor

Using this bundle cuts the hateoas serialization time by 50-90%, depending on how many / how complex the exclusion strategies are.

@mvrhov
Copy link

mvrhov commented Dec 18, 2014

So why don't you provide a PR to willdurand/BazingaHateoasBundle. And another bundle has to be installed?

@damienalexandre
Copy link
Contributor

There are some reasons for it:

  • this bundle is like a proof of concept, very opinionated implementation, and it's easy to plug or un-plug in case of issue or incompatibility;
  • there are some heavy changes from the original one - changes that users of HateoasBundle may not want:
    • we use Twig, which is not a dependency of HateoasBundle (we forgot to add it on the composer.json btw);
    • we write on the filesystem (cache directory);

If everybody agree about our changes, we would be more than happy to see those features on the core bundle 👍 - but it may need a new major version as this can introduce BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants