Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔴 BUG: Navigation drawer not closing #267

Open
rahilansari261 opened this issue Jun 20, 2023 · 9 comments
Open

🔴 BUG: Navigation drawer not closing #267

rahilansari261 opened this issue Jun 20, 2023 · 9 comments
Assignees
Labels
BUG Something isn't working enhancement New feature or request good first issue Good for newcomers

Comments

@rahilansari261
Copy link
Contributor

Navigation drawer not closing

When navigating to other pages by clicking navigation items it should close the navigation drawer

Expected behaviour
It should close the navigation drawer as we tap any item of the navigation drawer and navigate to the tapped page

@rahilansari261 rahilansari261 changed the title 🔴 BUG: 🔴 BUG: Navigation drawer not closing Jun 20, 2023
@ArslanYM ArslanYM added BUG Something isn't working enhancement New feature or request good first issue Good for newcomers labels Jun 20, 2023
@Sivasish48
Copy link
Contributor

Can I be assigned to this issue?
I would like to work on this issue.

@ArslanYM
Copy link
Owner

Sure @Sivasish48 . Assigned to you.

@Sivasish48
Copy link
Contributor

Can I get more detailed information about the issue?

@ArslanYM
Copy link
Owner

@Sivasish48 You should ask these type of questions before getting assigned to it. Anyways, the issue is when we navigate on small screen devices using the hamburger navbar, The hamburger doesnt close and stays opened.

@ashishratre404
Copy link
Contributor

Hey @Sivasish48, let me know if you need any help on this
I think it would be better to change the hamburger icon to an icon like 'X' when it is open, @ArslanYM what do you think about this?

@Sivasish48
Copy link
Contributor

Yess. I was also thinking about that X icon as well.. @ArslanYM would that be good?

@ArslanYM
Copy link
Owner

That's not the issue though, The 'X' when the drawer is open would be a feature but the issue here is to close the drawer when navigating to another page. @Sivasish48 Why has there been no update on this?

@ashishratre404
Copy link
Contributor

can I work on this? @ArslanYM

@ArslanYM
Copy link
Owner

@ashishratre404 Sure, Assigned to you. PR soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUG Something isn't working enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants