Skip to content

Commit 89b506d

Browse files
committedMay 18, 2020
Improve code
1 parent 6989e67 commit 89b506d

File tree

4 files changed

+4
-9
lines changed

4 files changed

+4
-9
lines changed
 

‎app/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ dependencies {
3939
implementation 'androidx.lifecycle:lifecycle-extensions:2.2.0'
4040
implementation 'androidx.recyclerview:recyclerview:1.1.0'
4141
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.2'
42-
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.5'
42+
implementation 'org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.6'
4343
implementation 'com.squareup.retrofit2:retrofit:2.8.0'
4444
implementation 'com.squareup.retrofit2:converter-gson:2.8.0'
4545
implementation 'com.github.bumptech.glide:glide:4.10.0'

‎app/src/main/java/com/slg/pokeonary/domain/UseCase.kt

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ package com.slg.pokeonary.domain
22

33
import com.slg.pokeonary.data.repository.common.ServiceResultWrapper
44

5-
abstract class UseCase<in RQ, RS> {
5+
interface UseCase<in RQ, RS> {
66

7-
abstract suspend fun buildAsync(params: RQ): ServiceResultWrapper<RS>
7+
suspend fun buildAsync(params: RQ): ServiceResultWrapper<RS>
88
}

‎app/src/main/java/com/slg/pokeonary/domain/pokemon/useCase/GetPokemonList.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import com.slg.pokeonary.domain.pokemon.model.Pokemon
66

77
class GetPokemonList(
88
private val pokemonRepository: PokemonRepository
9-
) : UseCase<GetPokemonListParams, List<Pokemon>>() {
9+
) : UseCase<GetPokemonListParams, List<Pokemon>> {
1010

1111
override suspend fun buildAsync(params: GetPokemonListParams) =
1212
pokemonRepository.getPokemonListAsync(params.start, params.count)

‎app/src/main/java/com/slg/pokeonary/mobile/pokemonList/PokemonListViewModel.kt

-5
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,9 @@
11
package com.slg.pokeonary.mobile.pokemonList
22

3-
import android.app.Application
4-
import android.content.Context
53
import androidx.lifecycle.LiveData
64
import androidx.lifecycle.MutableLiveData
75
import androidx.lifecycle.ViewModel
8-
import androidx.lifecycle.ViewModelProvider
96
import com.slg.pokeonary.data.repository.common.ServiceResultWrapper
10-
import com.slg.pokeonary.data.repository.pokemon.PokemonDataRepository
11-
import com.slg.pokeonary.data.repository.pokemon.dataSource.remote.PokemonRemoteDataSource
127
import com.slg.pokeonary.domain.pokemon.useCase.GetPokemonList
138
import com.slg.pokeonary.domain.pokemon.useCase.GetPokemonListParams
149
import com.slg.pokeonary.mobile.common.Event

0 commit comments

Comments
 (0)
Please sign in to comment.