Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DCDN class to extend base DCDN instead of EventEmitter #58

Open
vipyne opened this issue Dec 11, 2018 · 1 comment
Open

Refactor DCDN class to extend base DCDN instead of EventEmitter #58

vipyne opened this issue Dec 11, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@vipyne
Copy link
Contributor

vipyne commented Dec 11, 2018

Expected Behavior

const DCDN = require('ara-network-node-dcdn/dcdn')

class rewardDCDN extends DCDN { ...

Actual Behavior

const EventEmitter = require('events')

class DCDN extends EventEmitter { ...

in https://github.com/AraBlocks/ara-reward-dcdn/blob/master/src/dcdn.js#L30

Specifications

  • Version: 0.9.0
  • Platform:
  • Subsystem:
@vipyne vipyne self-assigned this Dec 11, 2018
@vipyne
Copy link
Contributor Author

vipyne commented Dec 11, 2018

sister issue: https://github.com/AraBlocks/ara-network-node-dcdn/issues/53

@vipyne vipyne removed their assignment Dec 13, 2018
@vipyne vipyne mentioned this issue Dec 13, 2018
Merged
@bplaster bplaster added the enhancement New feature or request label Dec 13, 2018
@madelinecameron madelinecameron mentioned this issue Dec 19, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bplaster @vipyne