Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify #previousAssociation #764

Open
MarcusDenker opened this issue Jul 1, 2024 · 0 comments
Open

Simplify #previousAssociation #764

MarcusDenker opened this issue Jul 1, 2024 · 0 comments

Comments

@MarcusDenker
Copy link
Contributor

With #760, we do not rely anymore on the idea that #previousAssociation returns the last item when called with a nil currentPage/currentKey.

The code right now is quite complex, it seems to come from this feature (but I am not really sure).

After merging the fix for #760, we should check if we can simplify #previousAssociation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Soil project board
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MarcusDenker