Merge pull request #884 from ApptiveGrid/cleanups

removed obsolete methods, added error for non-existing entries

Author: noha

src/Soil-Core/SoilConsistencyInspectorVisitor.class.st

@@ -20,7 +20,7 @@ SoilConsistencyInspectorVisitor >> addCluster: aSoilPersistentClusterVersion [
 ]
 
 { #category : #'as yet unclassified' }
-SoilConsistencyInspectorVisitor >> check: anObject using: aBlock proceed: aBoolean [
+SoilConsistencyInspectorVisitor >> check: anObject using: aBlock [
 	aBlock 
 		on: Error 
 		do: [ :error | 

src/Soil-Core/SoilConsistencyVisitor.class.st

@@ -10,27 +10,34 @@ Class {
 
 { #category : #checking }
 SoilConsistencyVisitor >> check [
-	self visit: soil
+	self visitWithTransaction: soil
 ]
 
 { #category : #'as yet unclassified' }
-SoilConsistencyVisitor >> check: anObject using: aBlock proceed: aBoolean [
+SoilConsistencyVisitor >> check: anObject using: aBlock [
 	aBlock 
 		on: Error 
 		do: [ :error | 
 			errors at: anObject put: error ]
 ]
 
 { #category : #'as yet unclassified' }
-SoilConsistencyVisitor >> checkCluster: cluster [
-	self checkObjectId: cluster objectId.
-	cluster references do: [ :ref | 
-		self checkObjectId: ref ]
+SoilConsistencyVisitor >> checkBehaviorDescription: objectId [
+	| description |
+	description := transaction objectWithId: objectId.
+	self check: description using: [  
+		soil behaviorRegistry 
+			nameAt: description behaviorIdentifier 
+			ifAbsent: [ Error signal: 'description for ', description behaviorIdentifier asString , ' cannot not be found in identifier index' ] ]
 ]
 
 { #category : #'as yet unclassified' }
-SoilConsistencyVisitor >> checkHeaderPage: headerPage [ 
-	self shouldBeImplemented.
+SoilConsistencyVisitor >> checkCluster: cluster [
+	self checkObjectId: cluster objectId.
+	cluster references do: [ :ref | 
+		self checkObjectId: ref ].
+	cluster behaviorDescriptions do: [ :description |
+		self checkBehaviorDescription: description ]
 ]
 
 { #category : #'as yet unclassified' }
@@ -46,7 +53,7 @@ SoilConsistencyVisitor >> checkPage: aPage [
 	self 
 		check: aPage 
 		using: [ aPage validate ] 
-		proceed: true
+	
 ]
 
 { #category : #'as yet unclassified' }

src/Soil-Core/SoilIndexConsistencyVisitor.class.st

@@ -48,6 +48,7 @@ SoilObjectSegment >> asCachedSegment [
 SoilObjectSegment >> at: anInteger [ 
 	| position |
 	position := indexFile positionAt: anInteger.
+	position isZero ifTrue: [  SoilIndexOutOfRange signal: 'no entry for object at ', id asString, ':', anInteger asString ].
 	^ (objectFile atPosition: position) ifNotNil: [ :record | 
 		record objectId: (SoilObjectId segment: id index: anInteger).
 		self soil notificationHandler recordRead: record.

src/Soil-Core/SoilObjectSegment.class.st

@@ -7,14 +7,6 @@ Class {
 	#category : #'Soil-Core-Visitor'
 }
 
-{ #category : #visiting }
-SoilTransactionalVisitor >> scan: aSoil [
-	soil := aSoil.
-	transaction := soil newTransaction.
-	[ self visit: aSoil ]
-		ensure: [ transaction abort ] 
-]
-
 { #category : #accessing }
 SoilTransactionalVisitor >> transaction [
 
@@ -26,3 +18,10 @@ SoilTransactionalVisitor >> transaction: anObject [
 
 	transaction := anObject
 ]
+
+{ #category : #visiting }
+SoilTransactionalVisitor >> visitWithTransaction: aSoil [
+	transaction := aSoil newTransaction.
+	[ self visit: aSoil ]
+		ensure: [ transaction abort ] 
+]