Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ python task.py list

# Complete a task
python task.py done 1

# JSON output for scripting
python task.py add "Buy groceries" --json
python task.py list --json
python task.py done 1 --json
```

## Testing
Expand Down
10 changes: 7 additions & 3 deletions commands/add.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def validate_description(description):
return description.strip()


def add_task(description):
def add_task(description, json_output=False):
"""Add a new task."""
description = validate_description(description)

Expand All @@ -31,7 +31,11 @@ def add_task(description):
tasks = json.loads(tasks_file.read_text())

task_id = len(tasks) + 1
tasks.append({"id": task_id, "description": description, "done": False})
task = {"id": task_id, "description": description, "done": False}
tasks.append(task)

tasks_file.write_text(json.dumps(tasks, indent=2))
print(f"Added task {task_id}: {description}")
if json_output:
print(json.dumps(task))
else:
print(f"Added task {task_id}: {description}")
17 changes: 13 additions & 4 deletions commands/done.py
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,14 @@ def validate_task_id(tasks, task_id):
return task_id


def mark_done(task_id):
def mark_done(task_id, json_output=False):
"""Mark a task as complete."""
tasks_file = get_tasks_file()
if not tasks_file.exists():
print("No tasks found!")
if json_output:
print(json.dumps({"error": "no_tasks", "message": "No tasks found!"}))
else:
print("No tasks found!")
return

tasks = json.loads(tasks_file.read_text())
Expand All @@ -31,7 +34,13 @@ def mark_done(task_id):
if task["id"] == task_id:
task["done"] = True
tasks_file.write_text(json.dumps(tasks, indent=2))
print(f"Marked task {task_id} as done: {task['description']}")
if json_output:
print(json.dumps(task))
else:
print(f"Marked task {task_id} as done: {task['description']}")
return

print(f"Task {task_id} not found")
if json_output:
print(json.dumps({"error": "not_found", "message": f"Task {task_id} not found"}))
else:
print(f"Task {task_id} not found")
11 changes: 7 additions & 4 deletions commands/list.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,21 @@ def validate_task_file():
return tasks_file


def list_tasks():
def list_tasks(json_output=False):
"""List all tasks."""
# NOTE: No --json flag support yet (feature bounty)
tasks_file = validate_task_file()
if not tasks_file:
print("No tasks yet!")
print("[]" if json_output else "No tasks yet!")
return

tasks = json.loads(tasks_file.read_text())

if not tasks:
print("No tasks yet!")
print("[]" if json_output else "No tasks yet!")
return

if json_output:
print(json.dumps(tasks))
return

for task in tasks:
Expand Down
9 changes: 6 additions & 3 deletions task.py
Original file line number Diff line number Diff line change
Expand Up @@ -25,22 +25,25 @@ def main():
# Add command
add_parser = subparsers.add_parser("add", help="Add a new task")
add_parser.add_argument("description", help="Task description")
add_parser.add_argument("--json", action="store_true", help="Output result as JSON")

# List command
list_parser = subparsers.add_parser("list", help="List all tasks")
list_parser.add_argument("--json", action="store_true", help="Output result as JSON")

# Done command
done_parser = subparsers.add_parser("done", help="Mark task as complete")
done_parser.add_argument("task_id", type=int, help="Task ID to mark done")
done_parser.add_argument("--json", action="store_true", help="Output result as JSON")

args = parser.parse_args()

if args.command == "add":
add_task(args.description)
add_task(args.description, json_output=args.json)
elif args.command == "list":
list_tasks()
list_tasks(json_output=args.json)
elif args.command == "done":
mark_done(args.task_id)
mark_done(args.task_id, json_output=args.json)
else:
parser.print_help()

Expand Down
33 changes: 33 additions & 0 deletions test_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,9 @@
import pytest
from pathlib import Path
from commands.add import add_task, validate_description
from commands.list import list_tasks
from commands.done import validate_task_id
from commands.done import mark_done


def test_validate_description():
Expand All @@ -28,3 +30,34 @@ def test_validate_task_id():

with pytest.raises(ValueError):
validate_task_id(tasks, 99)


def test_commands_support_json_output(tmp_path, monkeypatch, capsys):
"""Test JSON output for add, list, and done commands."""
monkeypatch.setattr(Path, "home", lambda: tmp_path)

add_task("Buy groceries", json_output=True)
created = json.loads(capsys.readouterr().out)
assert created == {"id": 1, "description": "Buy groceries", "done": False}

list_tasks(json_output=True)
listed = json.loads(capsys.readouterr().out)
assert listed == [created]

mark_done(1, json_output=True)
updated = json.loads(capsys.readouterr().out)
assert updated == {"id": 1, "description": "Buy groceries", "done": True}


def test_empty_json_outputs(tmp_path, monkeypatch, capsys):
"""Test JSON output when no tasks exist."""
monkeypatch.setattr(Path, "home", lambda: tmp_path)

list_tasks(json_output=True)
assert json.loads(capsys.readouterr().out) == []

mark_done(1, json_output=True)
assert json.loads(capsys.readouterr().out) == {
"error": "no_tasks",
"message": "No tasks found!",
}