Refactor: extract validation and path utilities to shared utils module#104
Open
lout33 wants to merge 1 commit into
Open
Refactor: extract validation and path utilities to shared utils module#104lout33 wants to merge 1 commit into
lout33 wants to merge 1 commit into
Conversation
- Create utils/validation.py with shared validate_description, validate_task_id, validate_task_file - Create utils/paths.py with shared get_tasks_file and get_config_path - Remove duplicated get_tasks_file and validation logic from add.py, list.py, done.py - Update commands to import from utils modules - Update tests to cover utils modules and verify refactoring Closes ApexOpsStudio#3
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor scattered validation and path utilities into shared
utils/module.Changes
utils/validation.pywith sharedvalidate_description,validate_task_id,validate_task_fileutils/paths.pywith sharedget_tasks_fileandget_config_pathget_tasks_fileand validation logic fromadd.py,list.py,done.pyTesting
Closes #3