-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Closed as not planned
Closed as not planned
Copy link
Description
Problem
TerminalGrid.tsx imports Group and Separator from react-resizable-panels, but:
- package.json specifies ^4.2.0
- package-lock.json locks to 3.0.6
- v3.0.6 and v4.2.0 both use the newer PanelGroup/PanelResizeHandle API
This causes build failures when doing a fresh install without using the lockfile.
Root Cause
Commit 30f7951 ("fix: resolve frontend lag and update dependencies") updated package.json to v4.2.0 but:
- Did not update the lockfile (still at v3.0.6)
- Did not update TerminalGrid.tsx imports to use the new API
Impact
- Low (currently): CI and normal npm install work because package-lock.json pins v3.0.6
- High (potential): Fresh installs without lockfile fail to build
- Medium: Creates confusion about which version is actually used
Files Affected
- apps/frontend/package.json - specifies ^4.2.0
- apps/frontend/package-lock.json - locks to 3.0.6
- apps/frontend/src/renderer/components/TerminalGrid.tsx - uses v3 API (Group, Separator)
Reproduction
- Delete package-lock.json
- npm install
- npm run build
- Build fails: "Group" is not exported by "react-resizable-panels"
Recommended Fix
Option 1 (Keep v3):
- Downgrade package.json to "react-resizable-panels": "3.0.6"
- Keep current TerminalGrid.tsx code
- Update lockfile
Option 2 (Upgrade to v4):
- Update TerminalGrid.tsx imports:
- Group → PanelGroup
- Separator → PanelResizeHandle
- Update lockfile to v4.2.0
- Test terminal grid functionality
Related
- Discovered while testing PR feat: auto-detect embedding provider from backend .env #571
- Affects fresh development environment setup
Metadata
Metadata
Assignees
Labels
No labels