Remove All mentions about Claude Desktop (vibe-kanban) - #75
Conversation
… Here's a summary of the changes made: ## Summary Removed all references to "Claude Desktop" across the following files: **Root level:** - `package.json` - Updated description to be generic - `CLAUDE.md` - Changed "MCP Apps (Claude Desktop)" to "MCP Apps" **Documentation:** - `docs/quickstart.md` - Updated platform table and description **packages/ui-react-builder:** - `src/index.ts` - Removed "(Claude Desktop)" from comment - `README.md` - Updated descriptions and autoResize documentation **packages/ui-react:** - `README.md` - Updated all references to use generic "MCP Apps" terminology **packages/ui:** - `README.md` - Updated host version example - `src/index.ts` - Updated platform detection comments - `src/types.ts` - Updated comments and example values - `src/adapters/mcp.ts` - Removed "Claude Desktop" from adapter comments - `src/adapters/types.ts` - Updated adapter implementation list - `tests/unit/detection.test.ts` - Updated test description - `tests/unit/mcp-adapter.test.ts` - Updated test description **packages/core:** - `README.md` - Updated description - `src/adapters/mcp.ts` - Removed "Claude Desktop, etc." from comments - `src/adapters/types.ts` - Updated protocol adapter documentation - `src/types/config.ts` - Updated protocol descriptions - `src/types/tools.ts` - Updated ToolContext documentation - `tests/unit/context.test.ts` - Updated test values **packages/create-app:** - `src/index.ts` - Replaced "Connecting to Claude Desktop" sections with generic MCP Apps host instructions **packages/testing:** - `src/ui/mock-host.ts` - Updated host platform example **examples/minimal:** - `README.md` - Replaced Claude Desktop config with generic MCP host instructions - `src/ui/GreetingWidgetV1.tsx` - Removed "Claude Desktop, etc." from comment **examples/restaurant-finder:** - `README.md` - Replaced Claude Desktop config with generic MCP host instructions
📝 WalkthroughSummary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings. WalkthroughThis PR updates documentation, comments, and package metadata to remove explicit "Claude Desktop" references and generalize naming to "MCP Apps" / "MCP Host", with no changes to runtime logic, types, or exported APIs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🧰 Additional context used🪛 LanguageToolexamples/restaurant-finder/README.md[grammar] ~80-~80: Ensure spelling is correct (QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1) ⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Comment |
Code Review: Remove Claude Desktop MentionsSummaryThis PR successfully removes specific mentions of "Claude Desktop" from comments and documentation, making the framework more generic for any MCP Apps-compatible host. The changes are consistent and well-executed across 24 files. ✅ Strengths
📋 Observations
🎯 RecommendationsMinor improvements (optional):
✅ Pre-Merge ChecklistBefore merging, ensure:
🎉 VerdictLGTM - This is a clean documentation/comment update that improves clarity and accuracy. The changes are consistent, well-scoped, and maintain code quality standards. The PR successfully achieves its goal of making the framework host-agnostic in its documentation. Suggested action: Approve and merge after CI checks pass. Review generated by Claude Code |
Code Review SummaryThis PR successfully removes references to Claude Desktop and makes the documentation more generic and host-agnostic. The changes align well with the goal of making MCP Apps Kit a platform-independent framework. ✅ Strengths
📋 Code Quality
🔍 VerificationChecked for any remaining references:
💡 Minor Observations
✅ RecommendationAPPROVE - This PR is ready to merge. The changes are:
No issues found. Great work on maintaining consistency across all 24 files! |
Claude Desktop doesn't use MCP Apps as for now. Le'ts remove the mention from comments and READMEs, keeping generic for any host using it.
Make sure that ALL the mentions are removed.