Skip to content

Remove All mentions about Claude Desktop (vibe-kanban) - #75

Merged
gabrypavanello merged 2 commits into
mainfrom
vk/1ba2-remove-all-menti
Jan 9, 2026
Merged

Remove All mentions about Claude Desktop (vibe-kanban)#75
gabrypavanello merged 2 commits into
mainfrom
vk/1ba2-remove-all-menti

Conversation

@gabe4coding

Copy link
Copy Markdown
Contributor

Claude Desktop doesn't use MCP Apps as for now. Le'ts remove the mention from comments and READMEs, keeping generic for any host using it.
Make sure that ALL the mentions are removed.

… Here's a summary of the changes made:

## Summary

Removed all references to "Claude Desktop" across the following files:

**Root level:**
- `package.json` - Updated description to be generic
- `CLAUDE.md` - Changed "MCP Apps (Claude Desktop)" to "MCP Apps"

**Documentation:**
- `docs/quickstart.md` - Updated platform table and description

**packages/ui-react-builder:**
- `src/index.ts` - Removed "(Claude Desktop)" from comment
- `README.md` - Updated descriptions and autoResize documentation

**packages/ui-react:**
- `README.md` - Updated all references to use generic "MCP Apps" terminology

**packages/ui:**
- `README.md` - Updated host version example
- `src/index.ts` - Updated platform detection comments
- `src/types.ts` - Updated comments and example values
- `src/adapters/mcp.ts` - Removed "Claude Desktop" from adapter comments
- `src/adapters/types.ts` - Updated adapter implementation list
- `tests/unit/detection.test.ts` - Updated test description
- `tests/unit/mcp-adapter.test.ts` - Updated test description

**packages/core:**
- `README.md` - Updated description
- `src/adapters/mcp.ts` - Removed "Claude Desktop, etc." from comments
- `src/adapters/types.ts` - Updated protocol adapter documentation
- `src/types/config.ts` - Updated protocol descriptions
- `src/types/tools.ts` - Updated ToolContext documentation
- `tests/unit/context.test.ts` - Updated test values

**packages/create-app:**
- `src/index.ts` - Replaced "Connecting to Claude Desktop" sections with generic MCP Apps host instructions

**packages/testing:**
- `src/ui/mock-host.ts` - Updated host platform example

**examples/minimal:**
- `README.md` - Replaced Claude Desktop config with generic MCP host instructions
- `src/ui/GreetingWidgetV1.tsx` - Removed "Claude Desktop, etc." from comment

**examples/restaurant-finder:**
- `README.md` - Replaced Claude Desktop config with generic MCP host instructions
@coderabbitai

coderabbitai Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Updated package metadata, READMEs and docs to use generic "MCP Apps" / "MCP Host" wording and revised Quickstart and example connection guidance to be host-agnostic.
  • Chores

    • Removed platform-specific branding and terminology from comments, examples, and help text across the repo for consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

Walkthrough

This PR updates documentation, comments, and package metadata to remove explicit "Claude Desktop" references and generalize naming to "MCP Apps" / "MCP Host", with no changes to runtime logic, types, or exported APIs.

Changes

Cohort / File(s) Summary
Root metadata & docs
CLAUDE.md, package.json, docs/quickstart.md
Generalized project description and table headers from "Claude Desktop" to "MCP Apps"; package description updated to "any MCP Apps-compatible host".
Example project docs
examples/minimal/README.md, examples/restaurant-finder/README.md, examples/minimal/...
Replaced "Connecting to Claude Desktop" with "Connecting to an MCP Apps Host"; removed Claude Desktop JSON example and added HTTP / Stdio connection guidance.
Core package docs & adapters
packages/core/README.md, packages/core/src/adapters/*.ts, packages/core/src/adapters/mcp.ts, packages/core/src/adapters/types.ts, packages/core/src/types/*.ts
JSDoc and header comments updated to refer to "MCP Apps" / hosts instead of "Claude Desktop"; no code or type changes.
Create-app scaffolding
packages/create-app/src/index.ts
Updated generated README text to instruct connecting to an MCP Apps host (HTTP and Stdio examples); removed Claude Desktop JSON snippet.
UI packages & builder
packages/ui-react-builder/README.md, packages/ui-react-builder/src/index.ts, packages/ui-react/README.md, packages/ui/README.md, packages/ui/src/*.ts
Documentation and example host names changed from "Claude Desktop" to "MCP Host"/"MCP Apps"; README option tables reworded; no API changes.
Tests & mocks
packages/core/tests/unit/context.test.ts, packages/ui/tests/unit/*.ts, packages/testing/src/ui/mock-host.ts
Test comments and a test userAgent string updated (e.g., "Claude Desktop/1.0" → "MCP Host/1.0"); test logic unchanged.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and clearly summarizes the main change: removing all mentions of Claude Desktop throughout the codebase to make references more generic.
Description check ✅ Passed The description is related to the changeset and explains the motivation: removing Claude Desktop mentions from comments and READMEs to keep wording generic for any host.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bce33d7 and 3a97457.

📒 Files selected for processing (2)
  • examples/restaurant-finder/README.md
  • packages/ui-react-builder/README.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/ui-react-builder/README.md
🧰 Additional context used
🪛 LanguageTool
examples/restaurant-finder/README.md

[grammar] ~80-~80: Ensure spelling is correct
Context: ...ndpoint: http://localhost:3000/mcp Stdio mode (for hosts that support it): ``...

(QB_NEW_EN_ORTHOGRAPHY_ERROR_IDS_1)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: test-and-lint
  • GitHub Check: claude-review
🔇 Additional comments (1)
examples/restaurant-finder/README.md (1)

72-84: ✅ Clear and appropriate removal of Claude Desktop references.

The new "Connecting to an MCP Apps Host" section (lines 72–84) appropriately replaces product-specific guidance with generic, reusable instructions for any MCP-compatible host. The two connection modes (HTTP endpoint and Stdio) are well-documented and actionable.

Note on static analysis: The LanguageTool hint flagging line 80 is a false positive—it misinterpreted the markdown formatting (**Stdio mode**) as a spelling error. The text is correct.

Please confirm that the endpoint http://localhost:3000/mcp and the npx command path align with the actual server configuration in this example app.


Comment @coderabbitai help to get the list of available commands and usage tips.

@claude

claude Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Code Review: Remove Claude Desktop Mentions

Summary

This PR successfully removes specific mentions of "Claude Desktop" from comments and documentation, making the framework more generic for any MCP Apps-compatible host. The changes are consistent and well-executed across 24 files.

✅ Strengths

  1. Comprehensive Coverage: The PR systematically updates all mentions across documentation, code comments, tests, and examples.

  2. Consistent Terminology: Adopts clear, generic terminology:

    • "Claude Desktop" → "MCP Apps" or "MCP Apps hosts"
    • "Claude Desktop/ChatGPT" → "MCP Apps/ChatGPT"
    • Maintains platform distinction where relevant
  3. Improved Documentation: Example READMEs now provide better guidance:

    • Shows both HTTP and stdio connection modes
    • Removes overly specific configuration examples
    • Makes it easier for users with different hosts
  4. No Breaking Changes: All changes are in comments, documentation, and test data—no API or behavior changes.

  5. Test Updates: Properly updates test assertions to match the new generic terminology (e.g., packages/core/tests/unit/context.test.ts:169-171).

📋 Observations

  1. Alignment with Reality: The PR description mentions "Claude Desktop doesn't use MCP Apps as for now"—this change future-proofs the documentation and makes it accurate for hosts that do support MCP Apps.

  2. Type Consistency: The changes maintain type safety and don't introduce any any types (adheres to strict TypeScript guidelines).

  3. No Unused Variables: All changes are to strings/comments only, no code logic affected.

🎯 Recommendations

Minor improvements (optional):

  1. Consider updating package.json description to be even more explicit:

    - "description": "Unified MCP Apps Builder SDK - Build MCP apps for any MCP Apps-compatible host from a single codebase",
    + "description": "Unified MCP Apps Builder SDK - Build MCP apps that work across multiple host platforms from a single codebase",
  2. The create-app README templates (packages/create-app/src/index.ts) now show generic connection instructions. Consider adding a comment or link to host-specific setup guides if they exist.

  3. Documentation clarity: The quickstart table (docs/quickstart.md:324-326) now reads:

    | Feature | MCP Apps | ChatGPT |
    

    Consider adding a note explaining that "MCP Apps" refers to any host implementing the MCP Apps protocol extension.

✅ Pre-Merge Checklist

Before merging, ensure:

  • pnpm build passes
  • pnpm test passes (especially check context.test.ts and detection.test.ts)
  • pnpm lint passes
  • pnpm typecheck passes

🎉 Verdict

LGTM - This is a clean documentation/comment update that improves clarity and accuracy. The changes are consistent, well-scoped, and maintain code quality standards. The PR successfully achieves its goal of making the framework host-agnostic in its documentation.

Suggested action: Approve and merge after CI checks pass.


Review generated by Claude Code

@claude

claude Bot commented Jan 9, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

This PR successfully removes references to Claude Desktop and makes the documentation more generic and host-agnostic. The changes align well with the goal of making MCP Apps Kit a platform-independent framework.

✅ Strengths

  1. Comprehensive coverage: All 24 files have been updated consistently, including:

    • Documentation (CLAUDE.md, quickstart.md, README files)
    • Code comments in adapters and types
    • Test files
    • Scaffolding templates in create-app
    • UI package documentation
  2. Consistency: The replacements maintain a consistent pattern:

    • "MCP Apps (Claude Desktop)" → "MCP Apps"
    • "Claude Desktop" → "MCP Apps hosts" or "MCP Apps-compatible host"
    • Configuration examples now show generic endpoints instead of specific JSON configs
  3. Improved neutrality: The changes make the framework feel more open and platform-agnostic, which should help with adoption across different MCP Apps implementations.

  4. Documentation improvements: The connection instructions in examples (minimal, restaurant-finder) and create-app templates are now more helpful:

    • Show both HTTP and stdio modes
    • Provide actual endpoint URLs instead of JSON config snippets
    • More actionable for developers using different hosts

📋 Code Quality

  • No logic changes: All changes are cosmetic (comments/docs), no runtime behavior affected
  • Type safety maintained: No TypeScript type changes
  • Adapter implementations unchanged: Core functionality in packages/core/src/adapters/mcp.ts and packages/ui/src/adapters/mcp.ts remains intact
  • Test assertions updated appropriately: Test in packages/core/tests/unit/context.test.ts now uses generic "MCP Host/1.0" instead of "Claude Desktop/1.0"

🔍 Verification

Checked for any remaining references:

  • ✅ No "Claude Desktop" references found
  • ✅ No "vibe-kanban" references found
  • ✅ No claude_desktop_config.json references found
  • ✅ No mcpServers configuration examples found

💡 Minor Observations

  1. Table formatting in quickstart.md: The table on lines 324-332 is well-aligned and correctly updated
  2. Package.json description: Updated to "Build MCP apps for any MCP Apps-compatible host" - clear and accurate
  3. Comment consistency: All JSDoc comments and inline comments updated consistently

✅ Recommendation

APPROVE - This PR is ready to merge. The changes are:

  • Thorough and complete
  • Consistent across the codebase
  • Non-breaking (documentation/comments only)
  • Aligned with the stated goal of platform neutrality

No issues found. Great work on maintaining consistency across all 24 files!

@gabrypavanello
gabrypavanello merged commit ba1ec4c into main Jan 9, 2026
4 checks passed
@gabrypavanello
gabrypavanello deleted the vk/1ba2-remove-all-menti branch January 9, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants