Skip to content

Commit 97a16c2

Browse files
Merge pull request #37 from drspaceboo/master
Add guard against NPE
2 parents 619ec19 + 37bbf60 commit 97a16c2

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

JniBitmapOperationsLibrary/jni/JniBitmapOperationsLibrary.cpp

+10-10
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniCropBi
8787
uint32_t right, uint32_t bottom)
8888
{
8989
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
90-
if (jniBitmap->_storedBitmapPixels == NULL)
90+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
9191
return;
9292
uint32_t* previousData = jniBitmap->_storedBitmapPixels;
9393
uint32_t oldWidth = jniBitmap->_bitmapInfo.width;
@@ -113,7 +113,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniRotate
113113
JNIEnv * env, jobject obj, jobject handle)
114114
{
115115
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
116-
if (jniBitmap->_storedBitmapPixels == NULL)
116+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
117117
return;
118118
uint32_t* previousData = jniBitmap->_storedBitmapPixels;
119119
uint32_t newWidth = jniBitmap->_bitmapInfo.height;
@@ -141,7 +141,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniRotate
141141
JNIEnv * env, jobject obj, jobject handle)
142142
{
143143
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
144-
if (jniBitmap->_storedBitmapPixels == NULL)
144+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
145145
return;
146146
uint32_t* previousData = jniBitmap->_storedBitmapPixels;
147147
uint32_t newWidth = jniBitmap->_bitmapInfo.height;
@@ -169,7 +169,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniRotate
169169
JNIEnv * env, jobject obj, jobject handle)
170170
{
171171
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
172-
if (jniBitmap->_storedBitmapPixels == NULL)
172+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
173173
return;
174174
uint32_t* pixels = jniBitmap->_storedBitmapPixels;
175175
uint32_t* pixels2 = jniBitmap->_storedBitmapPixels;
@@ -211,7 +211,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniFreeBi
211211
JNIEnv * env, jobject obj, jobject handle)
212212
{
213213
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
214-
if (jniBitmap->_storedBitmapPixels == NULL)
214+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
215215
return;
216216
delete[] jniBitmap->_storedBitmapPixels;
217217
jniBitmap->_storedBitmapPixels = NULL;
@@ -223,7 +223,7 @@ JNIEXPORT jobject JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniGet
223223
JNIEnv * env, jobject obj, jobject handle)
224224
{
225225
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
226-
if (jniBitmap->_storedBitmapPixels == NULL)
226+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
227227
{
228228
LOGD("no bitmap data was stored. returning null...");
229229
return NULL;
@@ -311,7 +311,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniScaleN
311311
uint32_t newHeight)
312312
{
313313
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
314-
if (jniBitmap->_storedBitmapPixels == NULL)
314+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
315315
return;
316316
uint32_t oldWidth = jniBitmap->_bitmapInfo.width;
317317
uint32_t oldHeight = jniBitmap->_bitmapInfo.height;
@@ -353,7 +353,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniScaleB
353353
{
354354

355355
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
356-
if (jniBitmap->_storedBitmapPixels == NULL)
356+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
357357
return;
358358
uint32_t oldWidth = jniBitmap->_bitmapInfo.width;
359359
uint32_t oldHeight = jniBitmap->_bitmapInfo.height;
@@ -486,7 +486,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniFlipBi
486486
JNIEnv * env, jobject obj, jobject handle)
487487
{
488488
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
489-
if (jniBitmap->_storedBitmapPixels == NULL)
489+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
490490
return;
491491
uint32_t* previousData = jniBitmap->_storedBitmapPixels;
492492
int width = jniBitmap->_bitmapInfo.width, middle = width / 2, height =
@@ -518,7 +518,7 @@ JNIEXPORT void JNICALL Java_com_jni_bitmap_1operations_JniBitmapHolder_jniFlipBi
518518
JNIEnv * env, jobject obj, jobject handle)
519519
{
520520
JniBitmap* jniBitmap = (JniBitmap*) env->GetDirectBufferAddress(handle);
521-
if (jniBitmap->_storedBitmapPixels == NULL)
521+
if (jniBitmap == NULL || jniBitmap->_storedBitmapPixels == NULL)
522522
return;
523523
uint32_t* previousData = jniBitmap->_storedBitmapPixels;
524524
int width = jniBitmap->_bitmapInfo.width, height =

0 commit comments

Comments
 (0)