Add reentrancy-style regression test for double-invocation of collect_fees in one ledger

[Jagadeeshftw]

📌 Description

collect_fees(asset) (admin-only) collects accrued protocol fees for an asset, and fees_accrued(asset) reads the uncollected amount. There should be an explicit test proving fees can't be double-counted if collect_fees is somehow invoked twice for the same asset before fees_accrued is properly zeroed (e.g. via a cross-contract call re-entering during the token transfer, if SEP-41 transfers are involved on this path).

🧩 Requirements and context

• Add a test invoking collect_fees(asset) twice in immediate succession and asserting the second call either collects 0 or errors, never re-collecting the same accrued amount.
• Confirm fees_accrued(asset) is zeroed (or decremented) before any external call/transfer within collect_fees, following checks-effects-interactions ordering.
• If a token transfer is involved on this path, verify it can't be used to reenter collect_fees mid-execution.

🛠️ Suggested execution

• Add the double-invocation test to src/test.rs.
• Review collect_fees's implementation order in src/lib.rs for checks-effects-interactions compliance; reorder if needed.

✅ Acceptance criteria

• Double-invocation of collect_fees never double-collects accrued fees.
• State is zeroed/decremented before any external interaction.
• Regression test locks in the guarantee.

🔒 Security notes

Directly protects protocol fee accounting from a reentrancy or race-style double-spend.

📋 Guidelines

• Minimum 95% test coverage
• Clear documentation
• Timeframe: 96 hours

[GBOYEE]

Hi \u2014 I can take this on (Add reentrancy-style regression test for double-invocation of colle...). I'll build the UI per the acceptance criteria. Happy to coordinate if anyone's already looking at it.

[grantfox-oss]

🦊 GrantFox — @mordabdul1 has been assigned to this issue as part of the Official Campaign | FWC26 campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #80)
2. Your PR will be reviewed by the AnchorNet-Org maintainers

Good luck! Track your progress on GrantFox.

[Jagadeeshftw]

@GBOYEE noted on the collect_fees reentrancy test, but with 6 issues already assigned to you and requests on many more open threads, we need to hold off assigning further work until some of that existing pile ships.

[Jagadeeshftw]

@GBOYEE update on the cap: on review, #99/#98/#91 already had a PR referencing them (PR #102), so those freed up. i used the freed slots for your three oldest pending requests (#97, #95, #81), which puts you back at the 6-issue cap. this one (#80) will have to wait until you close out some of what's assigned. thanks for the patience.

[Jagadeeshftw]

Thanks for applying here. Please also join our Telegram group here: https://t.me/+vTbe0hOUKrFhNTJl. It helps us keep communication clear while we review contributions.

[Jagadeeshftw]

Thanks for the application — I’ve assigned this to @mordabdul1. Please also join our Telegram group here: https://t.me/+vTbe0hOUKrFhNTJl. We share queue updates there while work is in progress.