Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Biome Changing Using Box Broken #1104

Open
Mdietrich88 opened this issue Sep 25, 2024 · 9 comments
Open

[Bug Report] Biome Changing Using Box Broken #1104

Mdietrich88 opened this issue Sep 25, 2024 · 9 comments
Labels
state: more information needed Information provided is incomplete type: bug Something isn't working

Comments

@Mdietrich88
Copy link

Bug Report

Current Behavior:

Refuses to set a specific y range as a certain biome even when box option is selected. Ends up doing the full y range instead

Expected behavior:

Correctly change the biome within the right y range selected

Steps To Reproduce:

Environment:

  • OS: Windows
  • Minecraft Platform: Bedrock
  • Minecraft Version: 1.20.30
  • Amulet Version: <10.36

Additional context

Attachments

Screenshots

Worlds

@Mdietrich88 Mdietrich88 added state: triage the severity of this ticket needs evaluating type: bug Something isn't working labels Sep 25, 2024
@gentlegiantJGC
Copy link
Member

Can you provide some more information.

Which selection mode do you have selected in the set biome settings?

@gentlegiantJGC gentlegiantJGC added state: more information needed Information provided is incomplete and removed state: triage the severity of this ticket needs evaluating labels Sep 25, 2024
@Mdietrich88
Copy link
Author

Mdietrich88 commented Sep 25, 2024

i am using the box mode. I am selecting 2 noninterfering height box selections and it wont allow it.

@Mdietrich88
Copy link
Author

Mdietrich88 commented Sep 25, 2024

i have a public Behavior pack addon that alters the overall height of the map but am choosing 2 groups of chunks
1 with a range of y=-64 to y=-50 and the 2nd is y=-51 to y=320 and it causes the lower biome to supersede the higher one

@Mdietrich88
Copy link
Author

Mdietrich88 commented Sep 25, 2024

Ok so after some testing it seems Amulet does not like the change in the world build height. As the addon allows for building from -512 to +512 on the y axis. Amulet does recognize the change in the Y axis range for other actions [import structures, fill, etc.], but the change biome operation does not. this addon uses the dimension file called overworld.json.

@Mdietrich88
Copy link
Author

pack.zip
This is the pack its made by the Discord user The World Foundry

@Mdietrich88
Copy link
Author

@gentlegiantJGC is this something that can be looked into and addressed or am i just screwed on being able to do such a thing

@Podshot
Copy link
Member

Podshot commented Sep 30, 2024

Not super well versed in the bedrock world format but from a quick look around with some debug statements I was able to figure out that there are chunks with varying min and max Y levels which is probably causing an issue somewhere, here's the data:

Last Saved Max Y Original Max Y Last Saved Min Y Original Min Y
512 320 -512 -64
512 512 -512 -512
0 320 0 -64
320 320 -64 -64
256 256 0 0
Chunk Heights (Last Saved Max, Original Max, Last Saved Min, Original Min) Number of Entries
(0, 320, 0, -64) 1
(512, 320, -512, -64) 1
(256, 256, 0, 0) 2
(512, 512, -512, -512) 2
(320, 320, -64, -64) 43

So it looks like there's a mix of chunks that haven't had their heights adjusted to the new datapack height, with the majority not having the new max/min heights of 512/-512 so the chance of the set biome operation running in a chunk that doesn't have the correct (modified by the pack) height is the highest, but more investigation is needed

@gentlegiantJGC
Copy link
Member

In Bedrock, block data is stored per sub-chunk and stores the Y coordinate.
I don't think the biome data stores the Y coordinate so we have to base this on the global floor height.
Perhaps there is something I am missing.

@Mdietrich88
Copy link
Author

Mdietrich88 commented Oct 7, 2024

In Bedrock, block data is stored per sub-chunk and stores the Y coordinate. I don't think the biome data stores the Y coordinate so we have to base this on the global floor height. Perhaps there is something I am missing.

I've gone around the entire map filling it with layers of stone going from -64 to -100 using the fill command to update the chunks height and it still won't update the chunks properly if you have any ideas on how to resolve this i would be very appreciative

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: more information needed Information provided is incomplete type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants