You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While saving the world, Amulet performs two steps-- pre-save operations, then saving chunks. The "elapsed time" counter does not reset between the two steps, but the progress bar does, so while Amulet runs the saving chunks task, the "remaining time" counter is calculated incorrectly.
Expected behavior:
To get an accurate "remaining time" counter, the "elapsed time" counter should reset just like does between running an operation and creating an undo point.
If you wanted to keep the behavior of the "elapsed time" counter showing the time spent on the entire save operation, an internal counter should be set for the "remaining time" counter to use once the pre-save operations are complete.
Steps To Reproduce:
Open a world
Make a large change
Save the world
Observe that during "Saving Chunks." the remaining time counter is not accurate.
Environment:
OS: Windows
Minecraft Platform: Java
Minecraft Version: 1.20.6
Amulet Version: V0.10.29
Screenshots
Screenshot of pre-save operations, which took a long time to complete (Remaining time is inaccurate here because my computer went to sleep during the operation, not due to any issue with the code)
Screenshot of saving chunks, which did not take long to complete, but the progress bar said it would take a very long time
The text was updated successfully, but these errors were encountered:
Bug Report
Current Behaviour:
While saving the world, Amulet performs two steps-- pre-save operations, then saving chunks. The "elapsed time" counter does not reset between the two steps, but the progress bar does, so while Amulet runs the saving chunks task, the "remaining time" counter is calculated incorrectly.
Expected behavior:
To get an accurate "remaining time" counter, the "elapsed time" counter should reset just like does between running an operation and creating an undo point.
If you wanted to keep the behavior of the "elapsed time" counter showing the time spent on the entire save operation, an internal counter should be set for the "remaining time" counter to use once the pre-save operations are complete.
Steps To Reproduce:
Environment:
Screenshots
Screenshot of pre-save operations, which took a long time to complete (Remaining time is inaccurate here because my computer went to sleep during the operation, not due to any issue with the code)
Screenshot of saving chunks, which did not take long to complete, but the progress bar said it would take a very long time
The text was updated successfully, but these errors were encountered: