Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Incorrect remaining time during world save #1051

Open
ICEREG1992 opened this issue May 27, 2024 · 1 comment
Open

[Bug Report] Incorrect remaining time during world save #1051

ICEREG1992 opened this issue May 27, 2024 · 1 comment
Labels
priority: low type: bug Something isn't working

Comments

@ICEREG1992
Copy link

Bug Report

Current Behaviour:

While saving the world, Amulet performs two steps-- pre-save operations, then saving chunks. The "elapsed time" counter does not reset between the two steps, but the progress bar does, so while Amulet runs the saving chunks task, the "remaining time" counter is calculated incorrectly.

Expected behavior:

To get an accurate "remaining time" counter, the "elapsed time" counter should reset just like does between running an operation and creating an undo point.

If you wanted to keep the behavior of the "elapsed time" counter showing the time spent on the entire save operation, an internal counter should be set for the "remaining time" counter to use once the pre-save operations are complete.

Steps To Reproduce:

  1. Open a world
  2. Make a large change
  3. Save the world
  4. Observe that during "Saving Chunks." the remaining time counter is not accurate.

Environment:

  • OS: Windows
  • Minecraft Platform: Java
  • Minecraft Version: 1.20.6
  • Amulet Version: V0.10.29

Screenshots

Screenshot of pre-save operations, which took a long time to complete (Remaining time is inaccurate here because my computer went to sleep during the operation, not due to any issue with the code)
image
Screenshot of saving chunks, which did not take long to complete, but the progress bar said it would take a very long time
image

@ICEREG1992 ICEREG1992 added state: triage the severity of this ticket needs evaluating type: bug Something isn't working labels May 27, 2024
@ICEREG1992
Copy link
Author

Probably a better image to show what I mean. Because "Elapsed Time" doesn't get reset, remaining time is artificially inflated.
image

@gentlegiantJGC gentlegiantJGC added priority: low and removed state: triage the severity of this ticket needs evaluating labels Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants