Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Keypresses not detected while holding down left mouse on button #1049

Open
Scroogeee opened this issue May 20, 2024 · 1 comment
Labels
state: triage the severity of this ticket needs evaluating type: bug Something isn't working

Comments

@Scroogeee
Copy link
Contributor

Scroogeee commented May 20, 2024

Bug Report

Current Behaviour:

Clicking the "move point 1" or "move point 2" or the "move box" buttons whilst applying keyboard input (WASD or space or shift) for the desired direction doesn't result in any movement.

Expected behavior:

The selection (point) should be moved according to the keyboard input while holding down the corresponding button with left mouse button.

Steps To Reproduce:

  1. Open a world in Amulet
  2. Select some area by left clicking
  3. Click one of the 3 Buttons (see attached screenshot) whilst applying keyboard input in any of the WASD or up (space) or down (Shift) direction
  4. See that selection bounding box is not moved.

Environment:

  • OS: OSX 14.4.1 Sonoma on Apple M1 Pro Chip (Silicon)
  • Minecraft Platform: Java
  • Minecraft Version: 1.20.6
  • Amulet Version: 0.10.29 with python version 3.11.9

Additional context

Adding debug println statements in _on_held of nudge_button.py shows that evt.action_ids doesn't contain the keypresses, but only ACT_BOX_CLICK.

Those keypresses should be contained in evt.action_ids of _on_held of nudge_button.py so that the

if any((x, y, z)):
    print("any xyz")
    self._move(self._rotate((x, y, z)))

portion of the code is called and (presumably) the points are actually moved.

Attachments

Screenshots

Worlds

@Scroogeee Scroogeee added state: triage the severity of this ticket needs evaluating type: bug Something isn't working labels May 20, 2024
@gentlegiantJGC
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: triage the severity of this ticket needs evaluating type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants