Input validation before creating an eFormidlings "shipment"

[SandGrainOne]

Description

I would like to suggest a small improvement to the eFormidlings client and business logic during the steps right before creating a shipment. The logic would need to look at the instance and its data elements to determine if a shipment can be successfully generated.

The first and most critical validation step would be to check for more than one attachment with the same filename. The integration point for eFormidling gives off an error message and crashes the process if the app is attempting to upload a file with a name that match an earlier upload.

The application owner can add logic like this themselves, but this one example should be built in I think.

Additional Information

I created this issue here in this repo even though I'm not sure exactly who it is that owns the eFormidlings client code. The code is hosted in the altinn-studio repository for the time being. I do assume that this would require some changes in the app lib code as well.

[ivarne]

I don't know much about eFormidling, but as far as I can tell this can be stopped at multiple stages.

• file analyzer/validator that (barring race conditions) prevents a user from uploading duplicate file names.

• normal task validation that prevents submission of attachments with duplicate file names. (User need to delete and reupload with unique names)

• logic in the preparation of the message that changes file names to be unique (eg add -1 postfix when required)

• use the element id (guid) instead of the file name from the upload request.

• (also suggested) provide a way to make the file names on the instance unique when uploading. This is race condition prone.

[martinothamar]

logic in the preparation of the message that changes file names to be unique (eg add -1 postfix when required)

I think this is the suggestion we're considering. Will investigate