Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement regression testing for Notifications with keywords #689

Open
7 tasks
Ahmed-Ghanam opened this issue Jan 10, 2025 · 1 comment
Open
7 tasks

Implement regression testing for Notifications with keywords #689

Ahmed-Ghanam opened this issue Jan 10, 2025 · 1 comment
Assignees

Comments

@Ahmed-Ghanam
Copy link
Contributor

Description

To ensure the proper functionality of notifications containing keywords, we will conduct comprehensive regression testing. These tests will verify that keywords in notification texts are accurately replaced with the appropriate values.

The regression tests will simulate various scenarios, including both valid and invalid keyword usage, to identify potential issues and maintain the integrity of the notification system.

Example

A notification with a keyword:

{
    "subject": "Security advice $recipientFirstName$!",
    "body": "Hi $recipientFirstName$, remember to never click on any links in emails from unknown senders.",
    "recipients": [
        {
            "nationalIdentityNumber": "18874198354"
        }
    ]
}

Expected result:

  • $recipientFirstName$ is replaced with the recipient's first name (e.g., "Ahmed").
  • The final notification reads:
    • Subject: "Security advice Ahmed!"
    • Body: "Hi Ahmed, remember to never click on any links in emails from unknown senders."

Additional Information

Refinement

  • Tests should be automated and reusable for future changes to the notification system.
  • Ensure integration with the existing regression test suite to provide comprehensive coverage.

Tasks

  • Review existing test cases to identify gaps in keyword-related scenarios.
  • Implement regression tests for notifications with keywords.
    • Test correct replacement of valid keywords.
    • Test handling of invalid or unsupported keywords.
  • Validate notifications with a mix of valid and invalid keywords.

Acceptance Criteria

  • Notifications containing keywords are correctly processed and validated.
  • Regression tests identify issues with keyword replacement or handling.
@Ahmed-Ghanam Ahmed-Ghanam self-assigned this Jan 10, 2025
@Ahmed-Ghanam Ahmed-Ghanam changed the title Implement regression tests for Notifications with keywords Implement regression testing for Notifications with keywords Jan 13, 2025
@Ahmed-Ghanam
Copy link
Contributor Author

Monday, January 20, 2025:
The existing test cases are designed to test the sending of emails to individuals or organizations and the delivery of SMS messages to specified mobile numbers. In this iteration, the email template has been updated to incorporate the two keywords introduced in implementation #545.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants