Skip to content

Commit e2ae0df

Browse files
committed
Updates.
1 parent bb35fb2 commit e2ae0df

File tree

3 files changed

+26
-18
lines changed

3 files changed

+26
-18
lines changed

s3/regression.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -198,6 +198,10 @@
198198
"implemented on antalya build with clickhouse version 24.12",
199199
check_clickhouse_version("<24.12"),
200200
),
201+
"minio/table function performance/wildcard": (
202+
Skip,
203+
"needs investigation",
204+
),
201205
":/hive partitioning": (
202206
Skip,
203207
"implemented on antalya build with clickhouse version 24.12",

s3/tests/common.py

Lines changed: 14 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1746,20 +1746,22 @@ def assert_row_count(self, node, table_name: str, rows: int = 1000000):
17461746
def check_consistency(self, nodes, table_name, sync_timeout=10):
17471747
"""SYNC the given nodes and check that they agree about the given table"""
17481748

1749-
with When("I make sure all nodes are synced"):
1750-
for node in nodes:
1751-
sync_replica(
1752-
node=node, table_name=table_name, timeout=sync_timeout, no_checks=True
1753-
)
1749+
for attempt in retries(timeout=100, delay=10):
1750+
with attempt:
1751+
with When("I make sure all nodes are synced"):
1752+
for node in nodes:
1753+
sync_replica(
1754+
node=node, table_name=table_name, timeout=sync_timeout, no_checks=True
1755+
)
17541756

1755-
with When("I query all nodes for their row counts"):
1756-
row_counts = {}
1757-
for node in nodes:
1758-
row_counts[node.name] = get_row_count(node=node, table_name=table_name)
1757+
with When("I query all nodes for their row counts"):
1758+
row_counts = {}
1759+
for node in nodes:
1760+
row_counts[node.name] = get_row_count(node=node, table_name=table_name)
17591761

1760-
with Then("All replicas should have the same state"):
1761-
for n1, n2 in combinations(nodes, 2):
1762-
assert row_counts[n1.name] == row_counts[n2.name], error()
1762+
with Then("All replicas should have the same state"):
1763+
for n1, n2 in combinations(nodes, 2):
1764+
assert row_counts[n1.name] == row_counts[n2.name], error()
17631765

17641766

17651767
@TestStep(Given)

s3/tests/table_function_performance.py

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,12 +37,14 @@ def s3_create_many_files(self):
3737

3838
@TestStep(When)
3939
def insert_files(self, folder_id, iteration):
40-
node.query(
41-
f"""INSERT INTO TABLE FUNCTION
42-
s3('{self.context.many_files_uri}id={folder_id}/file_{{_partition_id}}.csv','{access_key_id}','{secret_access_key}','CSV','d UInt64')
43-
PARTITION BY (d % {num_files_per_folder}) SELECT * FROM {table_name}
44-
-- {iteration}/{num_folders}"""
45-
)
40+
for attempt in retries(timeout=100, delay=10):
41+
with attempt:
42+
node.query(
43+
f"""INSERT INTO TABLE FUNCTION
44+
s3('{self.context.many_files_uri}id={folder_id}/file_{{_partition_id}}.csv','{access_key_id}','{secret_access_key}','CSV','d UInt64')
45+
PARTITION BY (d % {num_files_per_folder}) SELECT * FROM {table_name}
46+
-- {iteration}/{num_folders}"""
47+
)
4648

4749
with Given("I have a table with data"):
4850
simple_table(node=node, name=table_name, policy="default")

0 commit comments

Comments
 (0)