-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support JC2432W328C board #37
Comments
@DavidKarlas thank you for that. I liked what you did. Is it possible to disable the touch calibration for the other touch sensor like you did? Yes, you can open PRs. Could you also update the flasher site to let people choose the firmware they want to install based on their board? I remember seeing somewhere in the docs that the |
Which rises the question, should we try to detect board/screen/touch at runtime and only have 1 version which would simplify life of users? |
I dont know if it is possible to determine the peripheral at runtime. OS do that, so maybe it is. The only issue I can see is the size of the firmware increasing above what is permitted by the default partition table. If we create a single artifact that support different touch sensors, shipping one driver for each peripheral, there is a chance the build will exceed the max artifact size. I remember I had to disable lots of LGVL widgets at build time because I was having issues with the size of the artifact. I was thinking about having different builds for different boards because it is what I saw other projects doing. But if you can make it work the way you said, I don't have anything against it, since it would ease the installation. |
@DavidKarlas I won't publicly contribute to this project anymore |
@DavidKarlas feel free to contribute. I reopened it. I will be out of my computer until I can beat my mental health issues. |
Wishing you all the best, with love and hugs. Will see when I get back to this, for now I hacked version and deployed, works fine... |
I read
ESP32-2432S028
in README, went to Aliexpress, put that into search and ordered 3 boards... Turns out not allESP32-2432S028
are equal, my is with USB-C port(which I have problem powering via USB-C, but that is different story).Problem is that both screen(ST7789) and touch(CST820) are different models than this project.
I wonder if I were to open Pull Request... Would you like 2 different build configs for each board or would you prefer detection at runtime so only 1 firmware.bin can be published and distributed, making adoption easier for users, but at same time at least on first boot, multiple screens/touches will need to be probed...
Here is quick dirty commit I made to make it work: DavidKarlas@71ce58d which disabled calibration...
The text was updated successfully, but these errors were encountered: