From 0db3cad9e9db4f4c976fa05413decfa46b540c2f Mon Sep 17 00:00:00 2001 From: AliElDin Alaa <147806061+AliAlaa88@users.noreply.github.com> Date: Mon, 15 Dec 2025 15:52:51 +0200 Subject: [PATCH 1/3] fix: sonar errors --- .sonarlint/connectedMode.json | 5 + .vscode/settings.json | 6 + app/modules/Common/components/Logo/Logo.vue | 2 +- .../Common/components/Logo/LogoBlack.vue | 2 +- .../Common/components/Logo/LogoWhite.vue | 2 +- app/modules/Common/components/Popup/Popup.vue | 6 +- app/modules/Common/components/Tabs/Tabs.vue | 10 +- .../Common/components/UserCard/UserCard.vue | 2 +- .../Common/components/UserImage/UserImage.vue | 4 +- .../components/bookmarkList/bookmarkList.vue | 2 +- .../components/postTweet/PostTweet.vue | 18 +- .../subComponents/EmojiPicker/EmojiPicker.vue | 8 +- .../FormattedTextarea/FormattedTextarea.vue | 2 +- .../subComponents/GifPicker/GifPicker.vue | 16 +- .../subComponents/MediaUpload/MediaUpload.vue | 10 +- .../MentionSuggestion/MentionSuggestion.vue | 2 +- .../components/sidebar/MobileSidebar.vue | 16 +- .../TimeLine/components/sidebar/Sidebar.vue | 12 +- .../test/unit/useSidebarState.spec.ts | 6 +- .../views/TimeineView/TimelineView.vue | 4 +- .../auth/components/AuthLoadingPage.vue | 2 +- .../auth/components/CompleteAccount.vue | 12 +- app/modules/auth/components/OAuthComplete.vue | 2 +- app/modules/auth/components/createAccount.vue | 6 +- .../auth/components/forgetPassword.vue | 2 +- .../CompleteAccountComponents/Interests.vue | 20 +- .../CompleteAccountComponents/Language.vue | 18 +- .../ProfilePicture.vue | 22 +- .../CompleteAccountComponents/Username.vue | 22 +- .../auth/components/subComponents/OAuth.vue | 4 +- .../OAuthComponents/OAuthStep1.vue | 25 +- .../forgetPasswordStep1.vue | 20 +- .../forgetPasswordStep2.vue | 24 +- .../forgetPasswordStep3.vue | 26 +- .../loginComponents/loginStep1.vue | 30 +- .../loginComponents/loginStep2.vue | 30 +- .../components/subComponents/recaptcha.vue | 6 +- .../signupComponents/FinalRegister.vue | 26 +- .../signupComponents/createAccount.vue | 42 +- .../signupComponents/verifyOtp.vue | 26 +- .../auth/test/unit/resetPassword.spec.ts | 10 +- app/modules/auth/types/user.ts | 2 +- app/modules/auth/views/index.vue | 4 +- .../chat/components/ChatList/ChatList.vue | 2 +- .../ConversationItem/ConversationItem.vue | 2 +- .../components/ChatMessages/ChatMessages.vue | 4 +- .../SubComponents/InputBar/InputBar.vue | 12 +- .../SubComponents/Message/Message.vue | 2 +- .../CreateConversation/CreateConversation.vue | 6 +- .../chat/queries/useGetConversation.ts | 4 +- .../chat/services/ChatSocketService.ts | 368 +++++++++--------- .../chat/test/unit/TypingIndicator.spec.ts | 2 +- app/modules/chat/views/ChatView.vue | 2 +- .../explore/components/categories/index.vue | 2 +- .../components/categoryTweets/index.vue | 8 +- .../explore/components/forYou/index.vue | 10 +- .../explore/components/trending/index.vue | 2 +- .../explore/components/whoToFollow/index.vue | 4 +- .../explore/queries/useGetExploreQuery.ts | 2 +- .../explore/services/exploreService.mock.ts | 4 +- .../explore/services/exploreService.real.ts | 2 +- .../components/NotificationsList.vue | 6 +- .../SubComponents/NotificationCard.vue | 8 +- .../services/NotificationsSocketService.ts | 8 +- .../components/EditProfile/EditProfile.vue | 4 +- .../SubComponents/EditProfileAvatar.vue | 2 +- .../SubComponents/EditProfileCover.vue | 6 +- .../SubComponents/EditProfileForm.vue | 10 +- .../ProfileContent/ProfileContent.vue | 10 +- .../SubComponents/CoverImage.vue | 2 +- .../SubComponents/ProfileActions.vue | 2 +- .../SubComponents/ProfileAvatar.vue | 4 +- .../components/ProfilePhoto/CoverModal.vue | 2 +- .../components/ProfilePhoto/PhotoModal.vue | 2 +- app/modules/search/components/SearchBar.vue | 18 +- .../search/components/SearchHistory.vue | 4 +- .../search/components/SearchResults.vue | 4 +- .../search/components/SearchSuggestions.vue | 8 +- .../unit/useSearchSuggestionsQuery.spec.ts | 6 +- .../AccountInformations/ChangeCountry.vue | 8 +- .../AccountInformations/ChangeEmail.vue | 2 +- .../AccountInformations/ChangeUsername.vue | 2 +- .../SubComponents/ChangeEmailForm.vue | 2 +- .../SubComponents/VerifyEmailOTP.vue | 2 +- .../components/Display/DisplaySettings.vue | 4 +- .../Display/SubComponents/SlideBar.vue | 8 +- .../components/YourAccount/ChangePassword.vue | 6 +- .../components/YourAccount/DeleteAccount.vue | 2 +- .../SubComponents/ConfirmPassword.vue | 2 +- .../test/unit/ChangeEmailForm.spec.ts | 2 +- .../test/unit/LanguageSelector.spec.ts | 2 +- .../settings/test/unit/VerifyEmailOTP.spec.ts | 4 +- .../EditTweetModal/EditTweetModal.vue | 2 +- app/modules/tweets/components/Tweet/Tweet.vue | 12 +- .../Tweet/subComponents/Content/Content.vue | 2 +- .../subComponents/Publisher/Publisher.vue | 8 +- .../subComponents/Publisher/UserCard.vue | 2 +- .../subComponents/QuotedTweet/QuotedTweet.vue | 4 +- .../subComponents/TweetMedia/TweetMedia.vue | 2 +- .../components/TweetDetails/Reply/Reply.vue | 2 +- .../TweetDetails/Reply/ReplyForm.vue | 4 +- .../tweets/services/tweetService.mock.ts | 4 +- app/modules/tweets/test/unit/Content.spec.ts | 6 +- .../tweets/test/unit/Publisher.spec.ts | 6 +- .../tweets/test/unit/QuoteModal.spec.ts | 11 +- .../tweets/test/unit/QuotedTweet.spec.ts | 4 +- app/modules/tweets/test/unit/Reply.spec.ts | 8 +- .../tweets/test/unit/ReplyForm.spec.ts | 4 +- app/modules/tweets/test/unit/Stats.spec.ts | 10 +- .../tweets/test/unit/TweetMedia.spec.ts | 5 +- .../tweets/test/unit/useTweetActions.spec.ts | 6 +- app/pages/tweet/[id].vue | 6 +- app/pages/tweets/index.vue | 2 +- app/plugins/axios.ts | 6 +- app/plugins/socket.client.ts | 3 +- eslint.config.mjs | 21 +- package-lock.json | 76 ++++ package.json | 1 + tests/setup.ts | 34 +- vitest.config.ts | 3 +- 120 files changed, 740 insertions(+), 620 deletions(-) create mode 100644 .sonarlint/connectedMode.json create mode 100644 .vscode/settings.json diff --git a/.sonarlint/connectedMode.json b/.sonarlint/connectedMode.json new file mode 100644 index 00000000..0670e00d --- /dev/null +++ b/.sonarlint/connectedMode.json @@ -0,0 +1,5 @@ +{ + "sonarCloudOrganization": "alialaa88", + "projectKey": "AliAlaa88_Yapper-frontend", + "region": "EU" +} \ No newline at end of file diff --git a/.vscode/settings.json b/.vscode/settings.json new file mode 100644 index 00000000..8ecb4a05 --- /dev/null +++ b/.vscode/settings.json @@ -0,0 +1,6 @@ +{ + "sonarlint.connectedMode.project": { + "connectionId": "yapper", + "projectKey": "AliAlaa88_Yapper-frontend" + } +} diff --git a/app/modules/Common/components/Logo/Logo.vue b/app/modules/Common/components/Logo/Logo.vue index 76127387..b7a44cbb 100644 --- a/app/modules/Common/components/Logo/Logo.vue +++ b/app/modules/Common/components/Logo/Logo.vue @@ -1,6 +1,6 @@ diff --git a/app/modules/Common/components/Logo/LogoBlack.vue b/app/modules/Common/components/Logo/LogoBlack.vue index 9a90cb0e..e8d73617 100644 --- a/app/modules/Common/components/Logo/LogoBlack.vue +++ b/app/modules/Common/components/Logo/LogoBlack.vue @@ -1,5 +1,5 @@