Skip to content
This repository has been archived by the owner on Dec 30, 2020. It is now read-only.

Be able to select number of element for online songs #32

Open
H3llK33p3r opened this issue Apr 14, 2020 · 1 comment
Open

Be able to select number of element for online songs #32

H3llK33p3r opened this issue Apr 14, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@H3llK33p3r
Copy link

Hi, first thanks for your software. I used it yesterday and it is working great :) !

I have an enhancement feature for you. It will be cool to able to select the number of song displayed in the online song tab. I have check the API of https://beatsaver.com/ but unfortunatly, it seems that there is not possible. They use on their site an infinite scroll view :/.

Reading their code, the page size is an hardcoded value to 10 (https://github.com/lolPants/beatsaver-reloaded/blob/master/.env.example) and server routes are not developped to be able to give this value :(.

So either you can preload n pages of 10 elements in your side or may be create a request on the gihub to be able to give this parameter in their rest api ?

What do you think about that ?

@Alaanor
Copy link
Owner

Alaanor commented Apr 14, 2020

That's a good idea. Yeah, either I can pull request their beatsaver api, or I could create a pagination by multiple of 10 and loading n page for each page, that could work too. But I'm unsure if it's really worth implementing this. In any case the real solution instead of a workaround would be the PR on beatsaver.

@Alaanor Alaanor added the enhancement New feature or request label Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants