Fix Parse() then AST.toString() to restore square brackets on column names #2288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the time you are putting into AlaSQL!
Problem
alasql.parse()thenAST.toString()loses square brackets on column names that require them (spaces, periods, special chars).Fix
Modified
Column.toString()insrc/50expression.jsto handle column IDs stored as{val, wrap}objects by the parser.columnidis an object withvalandwrapproperties, reconstruct the original bracketed/backticked notationTest Coverage
Added
test/test1740.jswith 6 test cases:[Foo Bar]- space in column name[Foo.Bar]- period in column nameFooBar- regular column (no brackets added)`Foo Bar`)💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.