Fix primary key enforcement for IndexedDB tables #2274
Draft
+98
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for the time you are putting into AlaSQL!
Description
Fixes #1292 - Primary keys defined in CREATE TABLE were not enforced when using IndexedDB storage, allowing duplicate values.
Root cause:
IDB.createTablealways created object stores with{autoIncrement: true}, ignoring user-defined primary key columns.Changes:
IDB.createTable: Use IndexedDB'skeyPathoption for primary key columns{keyPath: columnName}{keyPath: [col1, col2, ...]}{autoIncrement: true}(unchanged behavior)IDB.intoTable: HandleConstraintErrorfrom IndexedDB when duplicate keys are inserted, returning consistent error messageExample:
Test: Added
test/test1292.jscovering column-level and table-level PK syntax.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
upload.wikimedia.org/usr/local/bin/node /usr/local/bin/node node_modules/mocha/bin/mocha.js ./test --reporter dot --bail(dns block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.